-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump weaver 4.5.0 and relevant mongodb changes #225
Conversation
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/796/Result : failure BIRDHOUSE_DEPLOY_BRANCH : weaver-4.5.0 DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-88.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/679/NOTEBOOK TEST RESULTS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor change suggested. Happy to see the Weaver component is completely independent now.
You'll have to bump2version minor
for this one since technically for those who had previously enable Weaver, they will need a manual data migration.
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/797/Result : failure BIRDHOUSE_DEPLOY_BRANCH : weaver-4.5.0 DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-88.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/680/NOTEBOOK TEST RESULTS |
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/800/Result : failure BIRDHOUSE_DEPLOY_BRANCH : weaver-4.5.0 DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-8.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/682/NOTEBOOK TEST RESULTS |
Look good to me, but I wonder if we should include a notice about the new mongo licence for releases since October 16, 2018 (3.4.0 was still under AGPL, but 5.0.4 is under SSPL). Birdhouse is meant to be public so it should not be a problem. |
I'm trying to see what this change of license implies. |
Exact, for us it doesn't change anything as everything is open. But for a potential Weaver or Birdhouse users it could be a deal breaker as they couldn't use the current stack along with private components. But maybe some other components are already under this kind of licence, I'm just hyper vigilent about mongo since I read about this change. So, maybe a simple notice in the changes.md along the new mongo version would be enough. |
@dbyrns Thanks for catching this. Legal stuff is not my strong suit. But it's something we should care about. |
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/805/Result : failure BIRDHOUSE_DEPLOY_BRANCH : weaver-4.5.0 DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-8.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/687/NOTEBOOK TEST RESULTS |
Changes
Weaver
version to 4.5.0 (from 4.2.1) for new features and fixes.Non-breaking changes
X-WPS-Output-Context
header to define the WPS output nested directory (for user context).X-Auth-Docker
header to define a private Docker registry authentication token when thereferenced Docker image in the deployed Application Package requires it to fetch it for Process execution.
MongoDB==5.0
Docker image for Weaver's database.dismiss
operation of job executions and retrieval of their results.Breaking changes
New MongoDB version 5.0 (as separate image for Weaver, not bump of the 3.4 used by Phoenix)
Because of the new
MongoDB==5.0
database requirement for Weaver that uses (potentially) distinct version from otherbirds (notably
phoenix
withMongoDB==3.4
), a separate Docker image is employed only for Weaver. If some processes,jobs, or other Weaver-related data was already defined on one of your server instances, manual transfer between the
generic
${DATA_PERSIST_ROOT}/mongodb_persist
to new${DATA_PERSIST_ROOT}/mongodb_weaver_persist
directory mustbe accomplished. The data in the new directory should then be migrated to the new version following the procedure
described in Database Migration.
Legal Notice
MongoDB==3.4
toMongoDB==5.0
, its license changes from AGPL to SSPL(reference: mongodb/mongo@6ea81c8/README#L89-L95).
This should not impact users using the platform for public and Open Source uses, but should be considered otherwise.
Related Issue / Discussion