-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose and restructure the documentation #118
Conversation
…rt more md to rst, Fix typos and formatting.
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Github browsing still broken with relative links.
You should be previewing the changes directly on Github and not in your IDE I think, so you can catch these errors faster.
…s, link to birdhouse and vagrant_variables.yml.example, more locations fixes
The links in RtD is also broken. ex: https://birdhouse-deploy--118.org.readthedocs.build/en/118/birdhouse/pavics-compose.sh. |
Went in a different direction and decided to make the GitHub links work by default, with the option of downloading a given file (they're copied to RtD as downloadable files). If we want, I can go in and replace all download links with the URL to these files on GitHub, but because they aren't markdown or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also from here https://birdhouse-deploy--118.org.readthedocs.build/en/118/, all the README links also do not resolve.
`README <birdhouse/README.rst>`_ and the various extra components | ||
`README for extra core components <birdhouse/components/README.rst>`_\ , | ||
`README for optional components <birdhouse/optional-components/README.md>`_. | ||
For GitHub navigation, see the following README pages: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just keep the original text "How to deploy the entire PAVICS platform, see the following README pages:" ... cuz it reads weird if user is actually on Github.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mention GitHub here because on RtD, clicking these links won't work, last I checked.
Oh true, those "download" links works on RtD https://birdhouse-deploy--118.org.readthedocs.build/en/118/deployment.html |
So I had a thought last night: GitHub navigation requires Markdown-like references ( EDIT: This would be overkill. I'm happy with the layout as it is. GitHub's functionality is primary. RtD navigation and file downloads work. @tlvu What I need to know is do we set links to the CFG/YAML/JSON files on GitHub or do we copy them to RtD and serve them from there? |
I would prefer copy to RtD and serve them from there so it is snapshotted. If we link to GH from RtD, I wonder how do we lock down the version (ie if RtD was built by By the way, I think we can accept having the So if you can copy the files to RtD so the relative links work both on RtD and GH and we can remove the annoying |
By the way, if we are going to keep the |
Short answer: It would be a huge pain to do this. We'd need to add commit hashes to everything, which would be feasible with Jinja, but a nightmare to maintain. Maybe there's a better way, but I don't know it.
It's fine, I needed the practice. I'm just glad it's nearly done.
The only way to do that would be to convert all the non-rst/md files to HTML source files using a different converter (vanilla Sphinx doesn't support this out of the box). It's worth looking into but not today. |
…e link dest and remove some useless empty lines
We want to enventually drop our custom build of geoserver or if we would keep it, it should be moved out to a separate repo.
@@ -0,0 +1 @@ | |||
../../vagrant_variables.yml.example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Zeitsperre What was this symlink for again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, it was to address the file access problem. I was exploring symlinking into the docs folder all the files I needed, but looks like you took a different approach. Looking at it all now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My other "approach" only works for files in birdhouse/
folder only, all other files still need the "download links" trick. So no nothing new, no change of direction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be interesting if we could use hard links both in /birdhouse
and under /docs/source/
, but that might cause issues in other ways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be interesting if we could use hard links both in
/birdhouse
and under/docs/source/
, but that might cause issues in other ways.
Not sure how this is going to solve our relative links on Github not working on RtD problem. What we really need is either
-
a way to copy files into the html output folder at any location we want (the option I found in db4d5aa only copy to the root of the html output folder)
-
a way to instruct RtD/Sphinx to rewrite all relative links to absolute link to Github at the same changeset of the build on RtD (ex: a relative link like
../env.local.example
should be replace withhttps://github.com/bird-house/birdhouse-deploy/blob/COMMIT_HASH_OF_RTD_BUILD/birdhouse/env.local.example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like the download link work-around but this will be for another day.
@Zeitsperre Check db4d5aa I found a way to directly copy some files to the html output but it only copies to the root, we are unable to specify any destination hierarchy. Pretty much the only feature missing to have relative link working both while browsing Github and on RtD !!! |
The documentation can be viewed inline when browsing on Github or on ReadTheDocs https://birdhouse-deploy.readthedocs.io.
Convert all
.md
files to.rst
files so they can be used on ReadTheDocs.Due to the hybrid goal (view doc both while browsing Github and on ReadTheDocs), some compromise had to be made:
all the relative links to other files in this repo are only working while browsing Github, not on RtD
a "download" link is added to all those relative links for RtD, but annoyingly those "download" link are also visible while browsing Github but not working
The current state is not perfect. We'll try to address the "relative links" vs "download links" work-around to have hybrid doc both when browsing Github and on ReadTheDocs another time.