Skip to content

Comments

Generalized stdout *clean version*#138

Draft
AlexPatrie wants to merge 16 commits intodevfrom
general-stdout
Draft

Generalized stdout *clean version*#138
AlexPatrie wants to merge 16 commits intodevfrom
general-stdout

Conversation

@AlexPatrie
Copy link
Contributor

What new features does this PR implement?
Please summarize the features that this PR implements. As relevant, please indicate the issues that the PR closes.

  • Adds Optional default setting for StandardOutputCapturerLevel to Config object through a validation block.
  • Adjusted default setting from "c" to "python" (resolves dependency on capturer #135)
  • Adds type annotations to functions

What bugs does this PR fix?
Please summarize the bugs that this PR fixes. As relevant, please indicate the issues that the PR closes.

Fixes frozen stdout and no-output issues like biosimulators/Biosimulators_COPASI#56
How have you tested this PR?
Pytest, and self testing.

@AlexPatrie AlexPatrie requested a review from eagmon May 10, 2023 19:51
@AlexPatrie AlexPatrie removed the request for review from eagmon May 11, 2023 15:37
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

dependency on capturer

1 participant