Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the CZT package was completely rewritten. Now supporting destination sizes and plans #34

Merged
merged 5 commits into from
Dec 11, 2023

Conversation

RainerHeintzmann
Copy link
Member

There are two things to discuss before merging:

  1. Look at this line:
using FourierTools, NDTools, Test
y = randn(ComplexF32, (5,6))
zoom = (2.0,2.0)
@test (real.(czt(y,zoom)),  select_region(upsample2(ft(y), fix_center=true), new_size=size(y)), rtol=1e-5)

This would normally be expected to be equal. Yet a closer inspection reveals, that an even sized array which is boadering to infinitely many zeros, into who's fouriertransform you zoom, should actually yield a different result. This also has to do with the position in the source, which is regarded as the center.

  1. It may be useful to use a named argument (e.g. new_size) instead of the unnamed dst_size, since this would require spelling out the dimensions even if one wants to use the default.

@codecov
Copy link

codecov bot commented Mar 4, 2023

Codecov Report

Merging #34 (21dec92) into main (de6204a) will decrease coverage by 0.02%.
The diff coverage is 94.89%.

@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
- Coverage   93.01%   92.99%   -0.02%     
==========================================
  Files          17       17              
  Lines         959     1028      +69     
==========================================
+ Hits          892      956      +64     
- Misses         67       72       +5     
Impacted Files Coverage Δ
src/czt.jl 93.51% <94.89%> (-2.56%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

docs/src/czt.md Show resolved Hide resolved
src/czt.jl Outdated Show resolved Hide resolved
src/czt.jl Show resolved Hide resolved
src/czt.jl Outdated Show resolved Hide resolved
src/czt.jl Outdated Show resolved Hide resolved
src/czt.jl Outdated Show resolved Hide resolved
@roflmaostc
Copy link
Member

Ready to merge?

@RainerHeintzmann RainerHeintzmann merged commit 4a0b19d into main Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants