Moving settings to the Web UI #350
Draft
+202
−122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 6, 2024 16:31
* PLAY_MONO_SPEAKER * SAVE_PLAYPOS_BEFORE_SHUTDOWN * SAVE_PLAYPOS_WHEN_RFID_CHANGE * SAVE_PLAYPOS_WHEN_RFID_CHANGE * USE_LAST_VOLUME_AFTER_REBOOT * VOLUMECURVE
|
Thanks for working on this. Can you remove your personal settings from the branch? And can you put the PR in "Draft" mode until it is ready (CI is green, etc.)? I can try to find some time for testing when it is ready. |
|
Personal settings were removed in the second commit if I'm not mistaken? Also see discussion here: https://forum.espuino.de/t/reduzierung-der-defines-stattdessen-einstellungen-in-web-ui/2798 |
Doesn't seem so. Just look at the overall changes of this PR and there are plenty of unrelated changes in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transferring defines from
settings.hto be manageable on the Web UI: