-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In the search feature field selectors, indicate which fields are metadata and which are rankings #191
Comments
Just covering a silly corner case for the new functionality of populateSelect() now that biocore#191 is done. Happy with how this commit's code works -- should really change many of the js tests to check the actual error messages thrown; chai makes testing this super easy
Something that could help with exploration is to enable searching by ranks in the So if the user wants to focus on the top 10 species and the bottom 10 species, they should be able to do this via something like filtering by rank as follows (the actual querying terminology will need some work).
This could be applied to also filter by log fold change (the y axis / the actual coefficients) On another note, the y axis in the rank plot should log-fold change, not The xaxis is the ranks - but sorted features is also fine. |
Thanks @mortonjt! Let me make sure we're on the same page here. re: New FeaturesFirst off, have you tried out the newest version of Qurro yet (in the open PR I have, which closes this issue)? This supports searching by the rank plot's y-axis values -- so not the actual ranks yet (i.e. x = 1, x = 2, x = 3, ...), but you can at least do something like Here's a screenshot of what the searching interface looks like in Qurro v0.3.0 -- In the future I'll probably add in something like So I think we're both in agreement there. The other thing you've brought up is the terminology—and if anything I'm saying in the application is off/incorrect, I definitely want to fix that! re: Terminology StuffRank plot y-axisIn the earliest earliest version of "rankratioviz" :), I think the y-axis said something to the effect of "log-fold change". I ended up changing this title to make it clear that the actual y-values of each feature in the rank plot change when you select a different ranking. So, right now, this says something like
Rank plot x-axisI guess I could make this say something like tl;drLet me know what you think of this stuff, or if I'm looking at this the wrong way. Happy to adjust plans/change around wordings to make this more useful + correct. |
ok - that is very cool, filtering by the coefficients should address the original issue Regarding the rank plot y-axis, maybe we can have a note to say that this is just the default? That being said, there are definitely exceptions to this rule. Both mmvec and LDA will not return log-fold units, and there are probably many others. How about this - maybe we can change it to something like ( In the meantime - we could also add in Before/After screenshots of how to change the title and y axis in the Vega editor. These screenshots could even be added to the wiki to show how plots can be customized. |
(sorry for taking a while to respond -- just got lunch) Understood. It's good to know that for most of these tools, differentials/loadings are in log-fold change. I like the suggestion of using As a semirelated question: is saying "Ranking" (not "Rank") in terms of the differential/loading fields in general ok? Most of Qurro's code and docs refer to the differential/loading fields (i.e. columns in the Songbird |
Update: just pushed a commit to the PR (140a57e) -- this changes the y-axis to now say e.g. |
will help alleviate confusion, esp. with songbird ranking names that are just metadata fields (I don't want people thinking "oh I'm going to select all features with a pH > 5," not that that really makes much sense... it should be clear instead that "oh I'm going to select all samples with a differential for the pH field > 5").
The text was updated successfully, but these errors were encountered: