Remove reliance on songbird for the differentials type in the future #154
Assignees
Labels
administrative
Logistical matters that don't have much or anything to do with code
optimization
Making code faster or cleaner
Milestone
Comments
fedarko
added
optimization
|
BTW, one thing you can do in your .travis config is update this to use a "dev env" version of QIIME 2 - then you will be able to test changes like the ones in qiime2/q2-types#212 right after the PR is merged (and busywork spits out a new dev env). |
|
Sorry, forgot the dev env link: https://dev.qiime2.org/latest/quickstart/ |
fedarko
added a commit
that referenced
this issue
Jun 5, 2019
Will make it easier to test things with newer Q2 versions. Thanks @thermokarst for letting me know this existed!
|
I had no idea that existed—this is really useful for immediately testing with the latest Q2 version. Thanks Matt! (I'm working on a dev branch of Qurro r/n but these changes should be merged back into master within a week or so) |
fedarko
added a commit
that referenced
this issue
Jun 22, 2019
This reverts commit 1d77e64. Once QIIME 2 2019.7 is released, I'll revert this revert (going back to testing with the dev version). However, the thing is -- the dev version currently available has the Differentials type definition merged in, which causes a conflict with songbird. So uhhh the best thing to do is keep testing with 2019.4, then switch over once all of the infrastructure is updated (and at this point we can say that Qurro only supports QIIME 2019.7).
fedarko
added a commit
to fedarko/qurro
that referenced
this issue
Jul 24, 2019
This reverts commit 7b5de90. So this is back to using the dev Q2 version, since it looks like it'll be simplest to just release v0.3.0 of Qurro alongside Q2 2019.7. need to fix the plugin_setup, etc. next
fedarko
added a commit
to fedarko/qurro
that referenced
this issue
Jul 30, 2019
This is a natural consequence of biocore#154. Hopefully, switching should be pretty painless for the majority of users. The error message in the plugin_setup should also be clear about what people need to do to fix their environments.
fedarko
added a commit
to fedarko/qurro
that referenced
this issue
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When qiime2/q2-types#212 is merged into a release of QIIME 2 (probs the next one, i.e. 2019.7), we can just require that at least that version of QIIME 2 is used with Qurro and remove our reliance on Songbird to define the Q2
FeatureData[Differential]type.Along with letting us clean up some complex/ugly code in
plugin_setup.py, this will impact the example jupyter notebook(s?),.travis.yml(no need to install songbird during the testing process), and some documentation I think. All in all this will make using Qurro easier.The text was updated successfully, but these errors were encountered: