Issue 246 #412
Merged
Issue 246 #412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@charles-cowart and I were just talking, and we need to implement a database patching system for this to work. I'll migrate the system from Qiita into this PR. |
|
This PR now includes the central elements of Qiita's patching system to allow for both Python and SQL patches if and as necessary for this project. |
charles-cowart
requested changes
Apr 2, 2019
|
@charles-cowart, are their outstanding items on the review to address? |
charles-cowart
approved these changes
Apr 5, 2019
|
@wasade Nope! Looks good, thanks! |
This was referenced Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this fixes #246, specifically it implicitly stores the creation timestamp for a given plate, that value is always returned by
Plate.list_plates, and the UI has been updated to display.Note the column widths in the display are not well balanced, but in my opinion that is a logically separate issue. I can solve in this PR if requested but it will require a reasonable degree of investigation.