Closes #329 change from timestamptz to timestamp for process dates #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antgonza
reviewed
Aug 23, 2018
| def integration_tests(): | ||
| """Creates one amplicon and one shotgun workflow from plating to sequencing | ||
| """ | ||
| samples = get_samples() |
There was a problem hiding this comment.
Just want to be sure that you want to delete vs. comment out these lines ... we are gonna need them back some time soon ...
There was a problem hiding this comment.
Fair point! I've put the lines to run the comparison back in but not the actual regex against which the comparison is done, as that will have to change pretty much from the ground up when we get around to bringing this feature back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated from PR 330, work by @antgonza :
closes #329 change from timestamptz to timestamp for process dates
fixes #336 ensure Process.get_date_format() is used for date display
fixes #326 disable preparation sheet download for shotgun runs