Skip to content

PoolListHandler.get would identify pools from future new protocols as amplicon sequencing pools #510

@AmandaBirmingham

Description

@AmandaBirmingham

The code in PoolListHandler.get identifies amplicon sequencing pools by process of elimination (i.e., any pool that is is not made up of any kind of known pool plate is treated as an amplicon sequencing pool):

https://github.com/jdereus/labman/blob/a5308e9c26a0344fd30e1c0c5e50c9a7d212fbef/labcontrol/gui/handlers/pool.py#L23-L39

This issue must be addressed before adding any new protocols or pool types to the system, because such an addition could lead this code to incorrectly identify pools based on these new protocols as amplicon sequencing pools.

LIkely makes sense to fix this in conjunction with #509 Centralize and harden identification of pool component types

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions