-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update transit to 3.3.8 #35222
base: master
Are you sure you want to change the base?
Update transit to 3.3.8 #35222
Conversation
This can no longer be built, since the statsmodel version it needs is 5 years old and no longer works with modern pandas for any recent python version. |
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request introduces several modifications to the Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
recipes/transit/meta.yaml (1)
Line range hint
28-28
: Update outdated statsmodels dependency.As mentioned in the PR comments, the current statsmodels requirement (>=0.9,<0.10) is outdated and may cause compatibility issues with modern versions of pandas and recent Python versions.
Please update the statsmodels dependency to a more recent version. You may want to check the compatibility of statsmodels with the other dependencies, especially numpy and scipy. Consider using a more relaxed version specifier to allow for future updates, for example:
- statsmodels >=0.13.0
Also, verify that this updated version is compatible with the new version of transit (3.3.6).
🧰 Tools
🪛 yamllint
[error] 18-18: trailing spaces
(trailing-spaces)
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/transit/meta.yaml (2 hunks)
🧰 Additional context used
🔇 Additional comments (4)
recipes/transit/meta.yaml (4)
2-2
: Version update looks good, but verify compatibility.The version update from 3.2.3 to 3.3.6 is consistent with the PR objective. However, this is a significant version bump that might introduce breaking changes or new features.
Please ensure that this new version is compatible with the current dependencies and doesn't introduce any breaking changes. You may want to check the changelog or release notes for version 3.3.6.
16-17
: Good addition of run_exports.The addition of the
run_exports
section is a good practice. It ensures that when this package is used as a dependency in other packages, it will be correctly pinned.This helps maintain consistency across the conda ecosystem and prevents potential compatibility issues.
36-36
: License specification improved.The license has been updated from GPL-3 to GPL-3.0-only, which provides more specificity about the license version.
This is a good practice as it removes any ambiguity about which version of the GPL license applies to this package.
10-10
: SHA256 checksum updated, verify correctness.The SHA256 checksum has been updated to match the new version's source tarball.
To ensure the integrity of the package, please verify that this checksum is correct for the v3.3.6 tarball. You can do this by downloading the tarball and computing its SHA256 hash:
Compare the output with the checksum in the meta.yaml file.
Update
transit
: 3.2.3 → 3.3.8recipes/transit
(click to view/edit other files)@mad-lab
This pull request was automatically generated (see docs).