Conversation
jsstevenson
commented
Aug 12, 2025
| dev = [ | ||
| "build ~= 0.8", | ||
| "ipython ~= 8.4", | ||
| "mypy-extensions ~= 1.0", |
Contributor
Author
There was a problem hiding this comment.
Not sure why this was here? not to do a chesterton's fence violation but I think it can be removed regardless of whether we keep pyright
There was a problem hiding this comment.
load-bearing unimported dependency
There was a problem hiding this comment.
probably was used for IDE hinting for anyone who had mypy installed
korikuzma
approved these changes
Aug 12, 2025
This was referenced Aug 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@korikuzma, @theferrit32, and I felt like biocommons repos probably aren't ready for type checking -- there are still too many coverage holes -- and that other, nascent type checking libraries might be better soon. Our feeling is that this should be kept out of precommit until the repos have better type annotations and the tooling has stabilized more.