Skip to content

Conversation

@BaconEggsRL
Copy link

@BaconEggsRL BaconEggsRL commented May 1, 2025

This PR begins the process of adding a Godot 4.0-compatible version of the project.
(Still a work in progress. Syntax is updated and project will run, but does not display data properly yet.)

Syntax changes
https://docs.godotengine.org/en/stable/tutorials/migrating/upgrading_to_godot_4.html

Changes to Tween
https://docs.godotengine.org/en/stable/classes/class_tween.html

Update:
Line charts mostly working now except for negative values. Some animations / tweens are still buggy, disabling for now.

Update 2:
Line and pie charts mostly working. Tweens are still disabled.

@BaconEggsRL BaconEggsRL mentioned this pull request May 1, 2025
@xsellier
Copy link
Contributor

xsellier commented May 7, 2025

Hey,

Thanks for the work, not sure we need to commit de .godot directory tho.

@BaconEggsRL
Copy link
Author

Hey,

Thanks for the work, not sure we need to commit de .godot directory tho.

Thanks! Removed .godot files
Finished up animations today. I think everything mostly works now. Feel free to try it out!
This was a fun exercise in converting the code. Hopefully some can find it useful

@xsellier
Copy link
Contributor

xsellier commented May 8, 2025

Thanks for the work. Do you mind squashing those commits into a single one please ?

@BaconEggsRL
Copy link
Author

Thanks for the work. Do you mind squashing those commits into a single one please ?

Took a bit but I think I figured that out 👯
Wasn't sure if I should have made a 4.x branch or not -- everything is on master.

@amanullahmenjli
Copy link

is there anything blocking this from being merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants