Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DecodeError::Other #602

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Conversation

odysa
Copy link
Contributor

@odysa odysa commented Nov 21, 2022

There is an EncodeError::Other(&'static str) in

bincode/src/error.rs

Lines 18 to 19 in ba4d196

/// An uncommon error occurred, see the inner text for more information
Other(&'static str),

but not in DecodeError.

I think adding Other(&'static str) to DecodeError makes errors more user-friendly.

@odysa odysa changed the title dd DecodeError::Other Add DecodeError::Other Nov 21, 2022
@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Base: 54.19% // Head: 54.19% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (66adf10) compared to base (ba4d196).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk     #602   +/-   ##
=======================================
  Coverage   54.19%   54.19%           
=======================================
  Files          50       50           
  Lines        4410     4406    -4     
=======================================
- Hits         2390     2388    -2     
+ Misses       2020     2018    -2     
Impacted Files Coverage Δ
src/error.rs 0.00% <ø> (ø)
src/de/impls.rs 58.24% <0.00%> (-0.27%) ⬇️
src/lib.rs 15.17% <0.00%> (-0.16%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@VictorKoenders VictorKoenders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants