Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode variant index instead of variant value #593

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

trevyn
Copy link
Contributor

@trevyn trevyn commented Oct 8, 2022

If this looks good, a new crates.io release of virtue is needed.

Closes #592

@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Base: 54.13% // Head: 54.23% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (0ccecfc) compared to base (61bbfbb).
Patch coverage: 91.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk     #593      +/-   ##
==========================================
+ Coverage   54.13%   54.23%   +0.10%     
==========================================
  Files          50       50              
  Lines        4437     4425      -12     
==========================================
- Hits         2402     2400       -2     
+ Misses       2035     2025      -10     
Impacted Files Coverage Δ
derive/src/derive_enum.rs 0.00% <0.00%> (ø)
tests/derive.rs 95.62% <100.00%> (-0.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@VictorKoenders
Copy link
Contributor

Virtue 0.0.10 is released

@trevyn trevyn marked this pull request as ready for review October 18, 2022 03:34
Copy link
Contributor

@VictorKoenders VictorKoenders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@VictorKoenders VictorKoenders merged commit a51d499 into bincode-org:trunk Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

negative explicit variant discriminator not allowed in enums
2 participants