Context 0.1: Implementation of varnum reading #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yoric
force-pushed
the
context-0.1
branch
2 times, most recently
from
588b121 to
a69d2d4
Compare
In this implementation, we rename `varnum` to `varu32`.
dominiccooney
approved these changes
Sep 3, 2019
| // Various versions of 0 | ||
| (vec![0], 0), | ||
| (vec![0b10000000, 0b00000000], 0), | ||
| (vec![0b10000000, 0b10000000, 0b00000000], 0), |
There was a problem hiding this comment.
Maybe also test a couple of multi-length, denormalized non-zero values?
There was a problem hiding this comment.
Looks like Travis is complaining about cargo fmt.
There was a problem hiding this comment.
Which values do you have in mind?
|
(fixing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, let's get porting context 0.1 to Rust started!