Add react example code to the README #183
Conversation
| @@ -72,6 +72,49 @@ That's it. Easy as apple pie. | |||
| </script> | |||
| </body> | |||
| </html> | |||
| ``` | |||
| ## React example (just loading videomail) | |||
| ``` | ||
| ## React example (just loading videomail) | ||
| ```jsx harmony | ||
| import React, { Component } from 'react'; |
There was a problem hiding this comment.
no semicolons, use the standard linter
|
|
||
| componentDidMount() { | ||
| (async() => { | ||
| console.log("waiting for videomail client library to load via CDN"); |
There was a problem hiding this comment.
remove or make it a comment instead
| componentDidMount() { | ||
| (async() => { | ||
| console.log("waiting for videomail client library to load via CDN"); | ||
| while(window.VideomailClient === undefined) |
There was a problem hiding this comment.
what if the remote resource is not available due to some network issues? this would loop forever ...
| <Helmet> | ||
| <script src="https://cdn.rawgit.com/binarykitchen/videomail-client/2.14.2/prototype/js/videomail-client.min.js" /> | ||
| </Helmet> | ||
| { |
There was a problem hiding this comment.
{ this.state.videomailClient && this.renderVideomail() }
would look easier to read
|
Thanks for this! Honestly I am not a fan of using CDN. Understand it's a limitation due to Gatsby being a SSR. That would mean your example is actually for Gatsby itself, not React. Because in a normal client-side React app we wouldn't have this problem. Submitted a review. |
|
Good point! Thanks for the review, I'll fix those issues. This is definitely a Gatsby example. I can cook up a react example, would you prefer to have the gatsby example on file somewhere or just a plain react example? |
|
Thanks. Plain React please. |
binarykitchen
force-pushed
the
develop
branch
3 times, most recently
from
f3872a1
to
944e61d
Compare
Submitting this is a talking point, feel free to suggest another way of adding this documentation.
I had to load using the CDN because of #181.