Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for streams / pipes #2

Merged
merged 1 commit into from
May 12, 2014

Conversation

skerit
Copy link
Collaborator

@skerit skerit commented May 8, 2014

I love the simplicity of your avconv library, but I was sorely lacking support for pipe:0 input and pipe:1 output.

This commit adds that.

All the informational data is now emitted as a 'message' event,
while the converted data is now using the 'data' event.

The 'end' event has also been renamed to 'exit', because the 'end' event makes the stream unreadable.

@binarykitchen
Copy link
Owner

Very nice @skerit, that's a great change! I added few comments here and there. Looking forward to your next round. And please, if you do not mind, please merge all the commits into a single one.

Just curious, why do you need pipe:0 and pipe:1 when you already can pass on the input via parameters with the current version?

@skerit
Copy link
Collaborator Author

skerit commented May 9, 2014

Alright, I took all the comments and fixed them. I squashed my commits into 1 single commit, which removed all the original comments and my response to them, though :/
Do you still have the mails of github?

Do you mean: why would you want to use pipes instead of regular files?

I need it for on-the-fly streaming of the converted data to browsers and such. And I need to do it with the least amount of latency as possible, so... :)

binarykitchen added a commit that referenced this pull request May 12, 2014
Add support for streams / pipes
@binarykitchen binarykitchen merged commit 74c2ef0 into binarykitchen:master May 12, 2014
@binarykitchen
Copy link
Owner

Wonderful, thanks for the changes. Merged. I will do few more changes and publish to npm soon.

Ummm, you make me curious regarding "on-the-fly" streaming? What's your current project and where do you need that feature? The reason why I am asking is because I am working on https://videomail.io ... have a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants