Skip to content
This repository was archived by the owner on Feb 22, 2024. It is now read-only.

Meenu/redirect row users #7177

Merged
merged 3 commits into from
Aug 9, 2022
Merged

Meenu/redirect row users #7177

merged 3 commits into from
Aug 9, 2022

Conversation

meenakshi-deriv
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Aug 3, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
binary-static ❌ Failed (Inspect) Aug 9, 2022 at 6:30AM (UTC)

@github-actions
Copy link

github-actions bot commented Aug 3, 2022 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/binary-static/pull/7177](https://github.com/binary-com/binary-static/pull/7177)
- **URLs**:
    - **w/ App ID + Server**: https://binary-static-git-fork-meenakshi-deriv-meenu-create-redi-7d3171.binary.sx/en/logged_inws.html?qa_server=frontend.binaryws.com&app_id=31372
    - **Original**: https://binary-static-git-fork-meenakshi-deriv-meenu-create-redi-7d3171.binary.sx/en/logged_inws.html
- **App ID**: `31372`

habib-deriv
habib-deriv previously approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@habib-deriv habib-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

habib-deriv
habib-deriv reviewed Aug 9, 2022
View reviewed changes
src/javascript/app/common/redirect_banner.js Outdated
// Set cookie if they wanted to stay at binary.com and no redirect
Cookies.set('binary-com-show', true, { expires: date });
} else {
window.location.replace('https://binary.bot/move-to-deriv');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the url to https://www.binary.bot/movetoderiv.html

src/javascript/app/common/redirect_banner.js Outdated
@@ -20,6 +23,23 @@ const RedirectBanner = (() => {

const handleRedirect = () => {
window.location.href = '/move-to-deriv/';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change here too

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@habib-deriv habib-deriv merged commit 2c54e0c into binary-com:master Aug 9, 2022
habib-deriv added a commit that referenced this pull request Aug 10, 2022
@habib-deriv
Revert "Meenu/redirect row users (#7177)"
f09b8ee 
This reverts commit 2c54e0c.
@habib-deriv habib-deriv mentioned this pull request Aug 10, 2022
Merged
habib-deriv added a commit that referenced this pull request Aug 10, 2022
@habib-deriv
Revert "Meenu/redirect row users (#7177)" (#7185)
c2d309f 
This reverts commit 2c54e0c.
habib-deriv added a commit that referenced this pull request Aug 10, 2022
@habib-deriv
Revert "Revert "Meenu/redirect row users (#7177)" (#7185)"
652a8bb 
This reverts commit c2d309f.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@habib-deriv habib-deriv habib-deriv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meenakshi-deriv @habib-deriv