Skip to content
This repository was archived by the owner on Feb 22, 2024. It is now read-only.

Mahdiyeh/fix: mlt_and_uk_market #6600

Merged
merged 5 commits into from
Jun 30, 2021
Merged

Mahdiyeh/fix: mlt_and_uk_market #6600

merged 5 commits into from
Jun 30, 2021

Conversation

mahdiyeh-deriv
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Jun 9, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/deriv/binary-static/9sd5v4YLBcFKDCr4658m1sFowuFk
✅ Preview: https://binary-static-git-fork-mahdiyeh-fs-fixmltandukmarket.binary.sx

@github-actions
Copy link

github-actions bot commented Jun 9, 2021 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/binary-static/pull/6600](https://github.com/binary-com/binary-static/pull/6600)
- **URLs**:
    - **w/ App ID + Server**: https://binary-static-git-fork-mahdiyeh-fs-fixmltandukmarket.binary.sx/en/logged_inws.html?qa_server=frontend.binaryws.com&app_id=27923
    - **Original**: https://binary-static-git-fork-mahdiyeh-fs-fixmltandukmarket.binary.sx/en/logged_inws.html
- **App ID**: `27923`

akmal-deriv
akmal-deriv reviewed Jun 10, 2021
View reviewed changes
akmal-deriv
akmal-deriv reviewed Jun 10, 2021
View reviewed changes
src/javascript/app/pages/trade/markets.jsx Outdated
const market_arr = Object.entries(this.markets).sort((a, b) => sortSubmarket(a[0], b[0]));
const non_crypto_markets_arr = market_arr.filter(market => is_not_crypto(market));
this.markets_all = non_crypto_markets_arr.slice();
final_markets_arr = market_arr.filter(market => is_not_crypto(market));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
final_markets_arr = market_arr.filter(market => is_not_crypto(market));

@mahdiyeh-deriv mahdiyeh-deriv changed the title Mahdieyh/fix: mlt_and_uk_market Mahdiyeh/fix: mlt_and_uk_market Jun 10, 2021
@mahdiyeh-deriv mahdiyeh-deriv force-pushed the fix_mlt_and_uk_market branch from e7c9d56 to bd9250f Compare June 10, 2021 07:28
akmal-deriv
akmal-deriv previously approved these changes Jun 10, 2021
View reviewed changes
@mahdiyeh-deriv mahdiyeh-deriv force-pushed the fix_mlt_and_uk_market branch from bd9250f to 0e2d672 Compare June 13, 2021 07:38
@mahdiyeh-deriv mahdiyeh-deriv force-pushed the fix_mlt_and_uk_market branch from 0e2d672 to a4367f0 Compare June 15, 2021 05:30
@mahdiyeh-deriv mahdiyeh-deriv force-pushed the fix_mlt_and_uk_market branch from a4367f0 to d13cca1 Compare June 15, 2021 07:19
@mahdiyeh-deriv mahdiyeh-deriv force-pushed the fix_mlt_and_uk_market branch from d13cca1 to 62abbe8 Compare June 15, 2021 07:21
mamali-fs
mamali-fs suggested changes Jun 15, 2021
View reviewed changes
@mahdiyeh-deriv mahdiyeh-deriv force-pushed the fix_mlt_and_uk_market branch from a2d3433 to 03df5a7 Compare June 16, 2021 09:15
@mahdiyeh-deriv mahdiyeh-deriv requested a review from mamali-fs June 16, 2021 09:16
@mamali-fs mamali-fs merged commit 5ae2b9a into binary-com:master Jun 30, 2021
@ali-fs ali-fs mentioned this pull request Jul 4, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mamali-fs mamali-fs mamali-fs approved these changes

@akmal-deriv akmal-deriv akmal-deriv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mahdiyeh-deriv @mamali-fs @akmal-deriv