This repository was archived by the owner on Feb 22, 2024. It is now read-only.
Webpack #1480
Merged
Webpack #1480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohammad-deriv
force-pushed
the
mohammad/webpack
branch
from
b873e29 to
c23101b
Compare
mohammad-deriv
force-pushed
the
mohammad/webpack
branch
from
973e8d0 to
5e25f91
Compare
mohammad-deriv
force-pushed
the
mohammad/webpack
branch
from
05a4174 to
dddbc04
Compare
small fix and remove extra lines
Pass all binary modules through webpack
mohammad-deriv
force-pushed
the
mohammad/webpack
branch
from
b4449ad to
c1baf5c
Compare
mohammad-deriv
force-pushed
the
mohammad/webpack
branch
from
3cdf960 to
44eacb3
Compare
Move lib to webpack
| texts_json: texts_json, | ||
| }; | ||
| END_EXPORTS | ||
| File::Slurp::write_file("$js_path/texts.js", {binmode => ':utf8'}, _texts().$exports); |
There was a problem hiding this comment.
might want to add a space around the . operator- coming from other languages this confuses people. Makes it look like a method call instead of concat.
There was a problem hiding this comment.
Done. Thanks @eugene-eeo
|
pls check conflicts |
|
Resolved. Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.