opendata swiss mapping #99
Conversation
docs/mapping/opendata_swiss.md
Outdated
| | Field | Type | Cardinality | Mapping | Comment | | ||
| |-----------------|---------|-------------|-------------------------|---------------------------------------------------| | ||
| | City | string | 1 | location.city | | | ||
| | Country | string | 1 | location.country | | |
There was a problem hiding this comment.
I suggest to map only EVSEDataRecord with Country = CHE/DEU/AUT/LIE
docs/mapping/opendata_swiss.md
Outdated
| | ParkingSpot | string | ? | evse.physical_reference | | | ||
| | PostalCode | string | 1 | location.postal_code | | | ||
| | Region | string | ? | | | | ||
| | Street | string | 1 | location.address | | |
There was a problem hiding this comment.
Comment: often includes house number
docs/mapping/opendata_swiss.md
Outdated
| | PostalCode | string | 1 | location.postal_code | | | ||
| | Region | string | ? | | | | ||
| | Street | string | 1 | location.address | | | ||
| | TimeZone | string | ? | location.time_zone | defaults to Europe/Zurich | |
There was a problem hiding this comment.
Should depend on Country. E.g., Europe/Berlin for DEU.
docs/mapping/opendata_swiss.md
Outdated
| | Floor | string | ? | | evse.floor_level | | ||
| | HouseNum | string | 1 | location.address | Added to Street. Might be '0', then it's ignored. | | ||
| | ParkingFacility | boolean | ? | | | | ||
| | ParkingSpot | string | ? | evse.physical_reference | | |
There was a problem hiding this comment.
is always null and can be ignored
docs/mapping/opendata_swiss.md
Outdated
| | Country | string | 1 | location.country | | | ||
| | Floor | string | ? | | evse.floor_level | | ||
| | HouseNum | string | 1 | location.address | Added to Street. Might be '0', then it's ignored. | | ||
| | ParkingFacility | boolean | ? | | | |
There was a problem hiding this comment.
can be null, true or false.
suggestion: map true to PARKING_LOT since Accessibility" is "Free publicly accessible" in this case
There was a problem hiding this comment.
can be null, true or false.
That's what the type boolean and the cardinality ? means: it's boolean (true, false), but optional, so it can be null, too.
map true to PARKING_LOT since Accessibility" is "Free publicly accessible" in this case
PARKING_LOT is a value which makes not much sense in OCPI in my opinion: I mean, what's the meaning of that? A charging station without a place to park at? The facility enum is rarely used in general, because adding this data is just a lot of work, and you can just make a radius search to get much better data.
| | PnC | | | ||
|
|
||
|
|
||
| ### DynamicInfoAvailable |
There was a problem hiding this comment.
For each EvseID the dynamic endpoint contains an EVSEStatus, so DynamicInfoAvailable can be ignored and EVSEStatus shall be evaluated.
There was a problem hiding this comment.
It is, there is no mapping set.
There was a problem hiding this comment.
Ok, in
ocpdb/docs/mapping/opendata_swiss.md
Line 221 in 9cec18d
docs/mapping/opendata_swiss.md
Outdated
| | EnvironmentalImpact | ? | ? | | Always null | | ||
| | EvseID | string | 1 | evse.evse_id | | | ||
| | GeoChargingPointEntrance | object | 1 | | Either {} or {"Google": "None None"}, both not useful | | ||
| | GeoCoordinates | [GeoCoordinates](#GeoCoordinates) | 1 | | | |
There was a problem hiding this comment.
GeoCoordinates section is missing
There was a problem hiding this comment.
Ah, yes, one of these "why the hell did you do this" fields :D
docs/mapping/opendata_swiss.md
Outdated
| | HardwareManufacturer | string | ? | | | | ||
| | HotlinePhoneNumber | string | 1 | | | | ||
| | HubOperatorID | string | ? | | | | ||
| | IsHubjectCompatible | string or boolean | 1 | 1 | String is `false` | |
There was a problem hiding this comment.
what does Mapping 1 mean?
There was a problem hiding this comment.
Copy paste fail from cardinality
| @@ -0,0 +1,215 @@ | |||
| # OpenData Swiss mapping | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Please mention that different charging points with same geo coordinates shall always be mapped to one charging station.
There was a problem hiding this comment.
This might sometimes lead to unexpected results, eg if when there are different opening times, but we have to choose one for the location. But I do see the point why this makes sense, so I would just warn about that.
There was a problem hiding this comment.
It seems that we just have to evaluate ChargingStationId, so EVSDDataRecords with the same ChargingStationId also have the same GeoCoordinates.
| @@ -0,0 +1,215 @@ | |||
| # OpenData Swiss mapping | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
It seems that we just have to evaluate ChargingStationId, so EVSDDataRecords with the same ChargingStationId also have the same GeoCoordinates.
docs/mapping/opendata_swiss.md
Outdated
| | ChargingPoolID | ? | ? | | Always null | | ||
| | ChargingStationId | string | 1 | evse.uid | | | ||
| | ChargingStationLocationReference | ? | ? | | Always null | | ||
| | ChargingStationNames | [ChargingStationName](#ChargingStationName) | * | location.directions | | |
There was a problem hiding this comment.
Multiple lang parameters do not really mean multple languages:
So location.name is fine for me, with de as preferred language.
| | PnC | | | ||
|
|
||
|
|
||
| ### DynamicInfoAvailable |
There was a problem hiding this comment.
Ok, in
ocpdb/docs/mapping/opendata_swiss.md
Line 221 in 9cec18d
docs/mapping/opendata_swiss.md
Outdated
|
|
||
| | Field | Type | Cardinality | Mapping | Comment | | ||
| |------------------|------------------|-------------|---------|---------| | ||
| | EVSEStatusRecord | EVSEStatusRecord | * | | | |
docs/mapping/opendata_swiss.md
Outdated
| | Test Station | | | ||
| | Restricted access | | | ||
| | Paying publicly accessible | | | ||
| | Key | Mapping | Commend | |
First OpenData Swiss mapping