Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of charging sessions and statistics URLs to v2 #622

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

Gr3yh0und
Copy link
Contributor

@Gr3yh0und Gr3yh0und commented Jun 12, 2024

Proposed change

The charging statistics and charging sessions URLs have changed in April 2024. Although they are not yet used in this project, this is probably helpful for other projects to be aware of.

Type of change

  • Bugfix (non-breaking change as this Consts aren't used yet)

Checklist

  • The code change is tested and works locally.

@rikroe
Copy link
Member

rikroe commented Jun 12, 2024

Thanks! I've also seen that some other endpoints have been updated, but haven't had the chance to go through everything. This PR is a good reminder to do that though.

@Gr3yh0und
Copy link
Contributor Author

No worries. I was just playing around with it and started building my own Python scripts to collect data and forward it to my TIG stack while I was coming along the statistics stuff and saw, that also other integrations of openHAB, HA, ioBroker and so on always seem to reference here as well. So probably tackling it in the point of truth might help also the other maintainers.

Are there any plans on having a look into the sessions/statistics from your side on the roadmap or should I maybe give it a try?

@rikroe
Copy link
Member

rikroe commented Jun 13, 2024

I don't have an EV, so don't need it personally and cannot test it.

There was #569 which implemented a lot but then it got stale. I would still prefer this as a type of remote service (#569 (comment)) as we don't need to get this every 5 minutes with the rest of the state.

So yeah, if you want to look at it, sure!

Copy link
Member

@rikroe rikroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rikroe rikroe merged commit d1f7d42 into bimmerconnected:master Jun 14, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants