Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add climatization status #527

Merged
merged 2 commits into from
Apr 26, 2023
Merged

Conversation

rikroe
Copy link
Member

@rikroe rikroe commented Apr 21, 2023

Proposed change

This PR adds (if available on vehicle):

  • climatization status (HEATING, COOLING, STANDBY, INACTIVE, UNKNOWN)
  • end time of climatization
  • True/False indicator if climatization is ON

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to this library)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works.

@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5073b39) 100.00% compared to head (133bfe2) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #527   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        18    +1     
  Lines         1410      1446   +36     
=========================================
+ Hits          1410      1446   +36     
Flag Coverage Δ
3.10 100.00% <100.00%> (ø)
3.11 100.00% <100.00%> (?)
3.7 100.00% <100.00%> (?)
3.8 100.00% <100.00%> (ø)
3.9 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bimmer_connected/vehicle/climate.py 100.00% <100.00%> (ø)
bimmer_connected/vehicle/vehicle.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rikroe rikroe requested a review from gerard33 April 26, 2023 21:15
@rikroe rikroe merged commit 02fb466 into bimmerconnected:master Apr 26, 2023
@mannibis
Copy link

mannibis commented Apr 28, 2023

Will this now make the Climate function 1 button (like the lock), instead of having a separate start and stop switch? I assume by reading the status of climatization we can now have a true single climate entity that will stay on after activating and turn off (or manually stopped), like a fan.

@rikroe
Copy link
Member Author

rikroe commented Apr 28, 2023

Will this now make the Climate function 1 button (like the lock)

Yes, this is the plan. At least for cars that return the climate state.
For others, we'll stay with the only one-shot buttons.

However the PR for HA is not yet open, so might take a little bit.

@mannibis
Copy link

mannibis commented May 4, 2023

So not sure it's me not doing something right but I don't see any new entities in the HA integration. Is the integration upgrade process automatic when updating HA? I'm on the 2023.5 release but it doesn't seem like the BMW integration is any different

@rikroe
Copy link
Member Author

rikroe commented May 4, 2023

Thanks for the reminder - open quite a lot of PRs to HA so forgot to actually add one climate status.

Maybe I'll find some time next week to implement it. I'll update in the discussion.

@rikroe rikroe deleted the climate-status branch October 20, 2023 20:22
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants