Skip to content

Conversation

@nickkt123
Copy link
Contributor

@nickkt123 nickkt123 commented Sep 23, 2025

Description

Hi, we recently merged the bimdata release into our platform and I had to fix some i18n issues for the new Project Notification Card. So I decided to created a PR to fix it in the bimdata platform too

  • added new i18n tokens
    • ProjectOverview.notifications.settings.activity.recipientsNotificationsText
    • ProjectOverview.notifications.settings.activity.[ged/visa/bcf/otherEvents].title
    • ProjectOverview.notifications.settings.general.sendAt
  • adjusted the German translations
  • removed unused/duplicate i18n tokens
    • ProjectOverview.notifications.settings.[bcf/visa].title
  • Bug fix (non-breaking change which fixes an issue) DON'T FORGET TO SEND THE PR INTO RELEASE
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

before/after

image image

Checklist

  • My code follows the code style of this project.
  • I have tested my code.
  • My code add or change i18n tokens
  • I want to run the tests for the commits of this PR

@nickkt123 nickkt123 marked this pull request as ready for review September 23, 2025 10:36
@NicolasRichel NicolasRichel self-requested a review September 24, 2025 07:22
@NicolasRichel
Copy link
Member

Hi @nickkt123 !

Thanks a lot for your contribution !
Your help on German translation is much appreciated. 🙏🏻

Nico

@NicolasRichel NicolasRichel merged commit 2770cc0 into bimdata:develop Sep 24, 2025
2 of 6 checks passed
Bimdata-io pushed a commit that referenced this pull request Nov 14, 2025
# [1.3.0](v1.2.9...v1.3.0) (2025-11-14)

### chore

* bump @bimdata/viewer@2.12.3-beta.10 from Github Actions [skip e2e] ([49d5c7d](49d5c7d))
* bump @bimdata/viewer@2.12.3-beta.11 from Github Actions [skip e2e] ([a191f36](a191f36))
* bump @bimdata/viewer@2.12.3-beta.12 from Github Actions [skip e2e] ([8cabbe4](8cabbe4))
* bump @bimdata/viewer@2.12.3-beta.13 from Github Actions [skip e2e] ([d658e6c](d658e6c))
* bump @bimdata/viewer@2.12.3-beta.14 from Github Actions [skip e2e] ([eb5a005](eb5a005))
* bump @bimdata/viewer@2.12.3-beta.15 from Github Actions [skip e2e] ([9a7821f](9a7821f))
* bump @bimdata/viewer@2.12.3-beta.16 from Github Actions [skip e2e] ([a5bbf43](a5bbf43))
* bump @bimdata/viewer@2.12.3-beta.2 from Github Actions [skip e2e] ([1ddf70f](1ddf70f))
* bump @bimdata/viewer@2.12.3-beta.3 from Github Actions [skip e2e] ([81b079c](81b079c))
* bump @bimdata/viewer@2.12.3-beta.4 from Github Actions [skip e2e] ([5cff6e8](5cff6e8))
* bump @bimdata/viewer@2.12.3-beta.5 from Github Actions [skip e2e] ([3d6a2a7](3d6a2a7))
* bump @bimdata/viewer@2.12.3-beta.6 from Github Actions [skip e2e] ([39beac4](39beac4))
* bump @bimdata/viewer@2.12.3-beta.7 from Github Actions [skip e2e] ([69a21d3](69a21d3))
* bump @bimdata/viewer@2.12.3-beta.8 from Github Actions [skip e2e] ([1482463](1482463))
* bump @bimdata/viewer@2.12.3-beta.9 from Github Actions [skip e2e] ([179aa8a](179aa8a))
* bump @bimdata/viewer@2.13.0-beta.1 from Github Actions [skip e2e] ([aabcc88](aabcc88))
* bump @bimdata/viewer@2.13.0-beta.2 from Github Actions [skip e2e] ([cec8c25](cec8c25))
* bump @bimdata/viewer@2.13.0-beta.3 from Github Actions [skip e2e] ([6096665](6096665))
* bump @bimdata/viewer@2.13.0-beta.4 from Github Actions [skip e2e] ([b90ffd7](b90ffd7))
* bump @bimdata/viewer@2.13.1-beta.1 from Github Actions [skip e2e] ([a112878](a112878))
* bump @bimdata/viewer@2.13.1-beta.2 from Github Actions [skip e2e] ([468eeff](468eeff))
* bump @bimdata/viewer@2.13.1-beta.3 from Github Actions [skip e2e] ([b634c23](b634c23))
* bump @bimdata/viewer@2.13.1-beta.4 from Github Actions [skip e2e] ([9a29e61](9a29e61))
* bump @bimdata/viewer@2.14.0 from Github Actions [skip e2e] ([c0c8a91](c0c8a91))
* bump @bimdata/viewer@2.14.0-beta.1 from Github Actions [skip e2e] ([880b0b0](880b0b0))
* bump @bimdata/viewer@2.14.0-beta.2 from Github Actions [skip e2e] ([c969f44](c969f44))
* bump @bimdata/viewer@2.14.0-beta.3 from Github Actions [skip e2e] ([31f7d04](31f7d04))
* bump @bimdata/viewer@2.14.0-beta.4 from Github Actions [skip e2e] ([c62fc66](c62fc66))
* bump @bimdata/viewer@2.14.0-beta.5 from Github Actions [skip e2e] ([81a4aa7](81a4aa7))
* bump @bimdata/viewer@2.14.0-beta.6 from Github Actions [skip e2e] ([e85b561](e85b561))
* bump @bimdata/viewer@2.14.0-beta.7 from Github Actions [skip e2e] ([ef1a27d](ef1a27d))
* bump @bimdata/viewer@2.14.0-beta.8 from Github Actions [skip e2e] ([7ebf77f](7ebf77f))
* bump @bimdata/viewer@2.14.0-beta.9 from Github Actions [skip e2e] ([943e72c](943e72c))
* update dependencies and node version to 24 in Dockerfile ([912f693](912f693))
* update env.example ([1ce9158](1ce9158))

### fix

* added missing i18n for ProjectNotificationCard (#580) ([2770cc0](2770cc0)), closes [#580](#580)
* remove defineModel useless import ([38846b9](38846b9))
* remove some dev code ([fb65176](fb65176))
* update bcf-components ([c806efe](c806efe))

### MINOR

* feat(bcf): add topic documents feature (#585) ([9478ba6](9478ba6)), closes [#585](#585)
* feat(bcf): add topic groups feature (#591) ([546c6a6](546c6a6)), closes [#591](#591)

### PATCH

* chore(deps): bump the minor-updates group across 1 directory with 8 updates (#597) ([961cdae](961cdae)), closes [#597](#597)
* disable LOD, enable DTX ([0ea1521](0ea1521))
* fix package version ([ec021d1](ec021d1))
* fix packages versions (2) ([30bcc9e](30bcc9e))
@Bimdata-io
Copy link
Contributor

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants