ENH: Add InterferometerList time domain plotting #920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj-will
approved these changes
Feb 24, 2025
Collaborator
mj-will
left a comment
mj-will
left a comment
There was a problem hiding this comment.
Thanks @mick-wright for adding this, LGTM.
ColmTalbot
approved these changes
Feb 24, 2025
mj-will
force-pushed
the
interferometer-list-time-domain-plotting
branch
from
fcc5621 to
265af82
Compare
lorenzopompili00
pushed a commit
to lorenzopompili00/bilby
that referenced
this pull request
Jun 30, 2025
* Added time domain plotting to InterferometerList * Added testing of plot_time_domain_data for InterferometerList --------- Co-authored-by: Mick Wright <mick.wright@ligo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the InterferometerList class has the
plot_datafunction for plotting the frequency domain strain for each of the detectors directly using their respectiveplot_datafunctions. However, to plot the time domain equivalent, one must loop the detectors manually. This PR simply adds an equivalent function for theplot_time_domain_datafunction. Testing has been added that mirrors theplot_datatesting.