Open
Conversation
not delete m_arg
|
yup, this is a big problem. Task doesnt know how are the function parameters allocated and I dont think we can work around this except what you said or leave it like this and let the caller figure out that it all must be dynamically alocated because otherwise delete will break. |
|
We could make it so that we dont use the function pointer. Instead we make a Task an abstract class that has an abstract Execute() method that is called by run from the threadpool. Then the client would have to inherit from Task, override Execute(), create an instance of his class and pass it, preferably, via reference to add method of threadpool |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it's better delete m_arg by user than threadpool do it.
Because of two reason: