Skip to content

build: use this tool to deploy itself #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2021
Merged

build: use this tool to deploy itself #84

merged 1 commit into from
Oct 23, 2021

Conversation

dianjuar
Copy link
Member

@dianjuar dianjuar commented Oct 23, 2021 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: https://www.conventionalcommits.org/en/v1.0.0/
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Both workspaces were tested Angular and Nx

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related change
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #83

What is the new behavior?

Plugin's deployment is done by the awesomeness tool that ever existed for that purpose. Itself 🙃

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This had something to do with #78

@dianjuar dianjuar force-pushed the use-this-tool-to-deploy-itself branch from cce50d0 to 8141646 Compare October 23, 2021 07:14
@dianjuar dianjuar merged commit c7dc795 into master Oct 23, 2021
@dianjuar dianjuar deleted the use-this-tool-to-deploy-itself branch October 23, 2021 07:14
@dianjuar dianjuar restored the use-this-tool-to-deploy-itself branch October 27, 2021 03:35
edbzn
edbzn reviewed Oct 27, 2021
View reviewed changes
Copy link

@edbzn edbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dianjuar I would recommend to remove the self dependency and directly point to the dist folder for the executor.

@dianjuar dianjuar deleted the use-this-tool-to-deploy-itself branch October 27, 2021 12:41
@dianjuar dianjuar mentioned this pull request Oct 28, 2021
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edbzn edbzn edbzn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dianjuar @edbzn