fix: save package in devDependencies #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the latest versions of the CLI `ng-add` packages can be added to `devDependencies` and this package is perfect for such use case since it's only needed for development. See: angular/angular-cli#15815
|
I saw that you are updating all the deployers 😄 Would be nice to have this fix on the original repo, that one that I used to create this deployer ngx-deploy-starter (Edit) |
|
I will run the unit and manual test to see if everything is Ok and then integrate it. Thank you so much for your contribution |
|
👍 |
dianjuar
approved these changes
Nov 7, 2019
|
@alan-agius4 since which version of the Angular/Cli this feature is available ? |
|
v9.0.0-next.10 |
dianjuar
pushed a commit
that referenced
this pull request
Jan 26, 2020
…c/handlebars-4.5.3 build(deps): bump handlebars from 4.1.2 to 4.5.3 in /src
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the latest versions of the CLI
ng-addpackages can be added todevDependenciesand this package is perfect for such use case since it's only needed for development.See: angular/angular-cli#15815