Skip to content

Improve navbar (for mobile)#683

Merged
mzur merged 4 commits intomasterfrom
mobile-navbar
Oct 24, 2023
Merged

Improve navbar (for mobile)#683
mzur merged 4 commits intomasterfrom
mobile-navbar

Conversation

@mzur
Copy link
Member

@mzur mzur commented Oct 23, 2023

So I was fed up with the navbar behavior on mobile for the final time. While we won't optimize all of BIIGLE for mobile anytime soon, at least the navbar should work. Here are the changes:

before after
desktop view:
Screenshot from 2023-10-23 16-30-33 Screenshot from 2023-10-23 16-30-38
Screenshot from 2023-10-23 16-44-16 Screenshot from 2023-10-23 16-43-19
mobile view:
Screen Shot 2023-10-23 at 16 31 06 Screen Shot 2023-10-23 at 16 31 04
Screen Shot 2023-10-23 at 16 31 13 Screen Shot 2023-10-23 at 16 31 10

@dlangenk Comments?

@dlangenk
Copy link
Member

@dlangenk Comments?

Really like that this is working right now. I have to say from a visual standpoint I liked the old design better without the outlines arround the objects, less button looking buttons, but I guess it's still worth it to have everything working without that much hassle.

@mzur
Copy link
Member Author

mzur commented Oct 24, 2023

Really like that this is working right now.

You mean you like the current behavior of the navbar (i.e. it gets larger on mobile and possibly hides content like in the annotation tool)?

I have to say from a visual standpoint I liked the old design better without the outlines arround the objects [...]

I stole that idea from GitHub again 😃 But if you have a strong opinion against it maybe we have to ask more people what they think. I've now updated the background color of the buttons so they are less "intruding":

image

@dlangenk
Copy link
Member

dlangenk commented Oct 24, 2023

Really like that this is working right now.

You mean you like the current behavior of the navbar (i.e. it gets larger on mobile and possibly hides content like in the annotation tool)?

Nope I mean the new layout (the "after")

I have to say from a visual standpoint I liked the old design better without the outlines arround the objects [...]

I stole that idea from GitHub again 😃 But if you have a strong opinion against it maybe we have to ask more people what they think. I've now updated the background color of the buttons so they are less "intruding":

image

Yes, I like that better. Can keep it that way I'd say.

@mzur
Copy link
Member Author

mzur commented Oct 24, 2023

Alright, thanks!

@mzur mzur merged commit 6798696 into master Oct 24, 2023
@mzur mzur deleted the mobile-navbar branch October 24, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants