Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the marlin_fullscreen parameter in config.ini doesn't work. #716

Merged
merged 2 commits into from
May 27, 2020

Conversation

Uz45
Copy link
Contributor

@Uz45 Uz45 commented May 25, 2020

Requirements

All supported screens.

Description

In the config.c file the code reading the marlin_fullscreen parameter from the config.ini file is missing.

Benefits

Defining the marlin_fullscreen parameter via the config.ini file

Related Issues

Copy link
Contributor

@digant73 digant73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a cosmetic review. According to the config.ini file, marlin_fullscreen parameter is placed before marlin_title parameter. So even in the code it should be put before and not after marlin_title

@Uz45
Copy link
Contributor Author

Uz45 commented May 27, 2020

just a cosmetic review. According to the config.ini file, marlin_fullscreen parameter is placed before marlin_title parameter. So even in the code it should be put before and not after marlin_title

Yes, it makes more sense. Thanks!

@bigtreetech bigtreetech merged commit 7634bbb into bigtreetech:master May 27, 2020
jeffeb3 pushed a commit to jeffeb3/BIGTREETECH-TouchScreenFirmware that referenced this pull request Jul 20, 2020
…reetech#716)

Fix the marlin_fullscreen parameter in config.ini doesn't work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants