FW size reduction & bugfixes #2766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kisslorand
force-pushed
the
Minor-size-reduction
branch
6 times, most recently
from
22aa0a1 to
e25e36c
Compare
kisslorand
force-pushed
the
Minor-size-reduction
branch
from
e25e36c to
f64e550
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
BTT or MKS TFT
Description
This PR is mostly about size reduction but it also brings some bug fixes.
The bugs fixed are:
Upon first time entering to "Caselight" menu if brightness is already set to any other value than 0 (zero) and the caselight is in "off" state, by setting the state to "on" the brightness resets to 0 (zero). On a later access to "Caselight" menu if the caselight is in "off" state and the caselight brightness was changed by any other guest connected to the mainboard (Octoprint, Pronterface, etc), by setting the state to "on" the brightness resets to the last value that was set by the TFT.
In "Home Offset" menu the offset can be set outside the predefined minimum and maximum limits but once passing those limits the offset cannot be adjusted anymore.
Benefits
Related Issues