Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save/load infoSettings Struct instead of save/load every variable individually, Fix Screen freezes/Click to Resume message/damaged M105 command in Marlin mode #1468

Merged
merged 15 commits into from
Jan 7, 2021

Conversation

guruathwal
Copy link
Contributor

@guruathwal guruathwal commented Dec 31, 2020

Fixes #1433 , fixes #1383, fixes #1297

@digant73
Copy link
Contributor

digant73 commented Dec 31, 2020

please remove config.ini. I already merged your changes (you reported in this PR) in mine. Have a look to my PR and let me know if something is missing

@rightawy
Copy link

rightawy commented Jan 1, 2021

@digant73 you should not ask anyone to remove there work and copy it to yours.

@digant73
Copy link
Contributor

digant73 commented Jan 1, 2021

@rightawy it is pretty much useless to provide something that was already added in an existing and specific PR and that was also notified in the related bug.

@oldman4U
Copy link
Contributor

oldman4U commented Jan 1, 2021

Good to see that we do not have enough bugs to fix and open feature requests, so that several developers are working on the same topic again.

Just as a reminder: #1170 and #1218 ;-)

Thank you

@guruathwal guruathwal changed the title save/load infoSettings Struct instead of save/load every variable individually, add missed level_edge_distance save/load infoSettings Struct instead of save/load every variable individually, Fix Screen freezes/Click to Resume message/damaged M105 command in Marlin mode Jan 5, 2021
@bigtreetech bigtreetech merged commit c367983 into bigtreetech:master Jan 7, 2021
Uz45 added a commit to Uz45/BIGTREETECH-TouchScreenFirmware that referenced this pull request Jan 9, 2021
save/load infoSettings Struct instead of save/load every variable individually, Fix Screen freezes/Click to Resume message/damaged M105 command in Marlin mode bigtreetech#1468
jeffeb3 pushed a commit to V1EngineeringInc/BIGTREETECH-TouchScreenFirmware that referenced this pull request Nov 10, 2021
…ividually, Fix Screen freezes/Click to Resume message/damaged M105 command in Marlin mode (bigtreetech#1468)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants