-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coding standards, language pack size check during compiling, fix incorrect temperature for mixing hotend, reduce program memory usage #1427
Conversation
In some menus you now passed an unitialized buffer to numPad funtion. Also in PID menu the tool index is now wrongly set befor the loop detecting it. Just a very quick check, so probably other errors are present. |
Small feedback on the guidestyle:
(Didn't take the time to read the whole thing) |
@digant73 Editing code line will affect the comment alignment in every style even when the comments are aligned to the far right side. it will also require frequent indentation changes when a line is changed. The benefit of the style suggested in this PR is that it can be easily programmed via clang-format to auto-indent the comments removing the need to manually fix everything manually. @traffic-light I did not add |
…incorrect temperature for mixing hotend, reduce program memory usage (bigtreetech#1427)
Fixes Multi extruder Cold extrusion prevent #1419