resolves #1377 + cleanup

[digant73]

BUG FIXES:

• resolves [BUG] (MBL - No Mesh Saved - No Mesh In Editor) #1377 (Mesh Editor freeze after one of the last merged PR)
• resolves Zoffset menu issue : the nozzle dives into the bed after modifications on hotend #1364: Z Offset will start from probing Z0 point instead of absolute Z0 point. It means original Z offset is not applied when Z offset is enabled on Z offset menu
• resolves Z-offset menu bug, cause X,Y axis Impact structure #1363 (probably solved now)
• resolves Question about "fil_runout:" in the config.ini file #1353 (value "SMART" for "fil_runout" is now correctly read from config.ini)
• MBL safe starting Z point: initial Z points are now set to 1mm instead of Z0. This should make more safe the MBL process in case of warped bed or not good manual leveling
• some cleanup

PR STATE:

• FINAL: Ready to be merged with BTT main branch:

[ETE-Design]

@digant73 See my last comment on #1377 Seems like it dosen't fix it :-(

[radek8]

The repair works.
Problem #1377 solved.

[ETE-Design]

@radek8 Still have the problem even with this fix :-(

[digant73]

The previous code was restored and is working properly now. You probably missed something. Retry please

[Octet-nl]

This does not fix #1363.

I had to remove this line (around line 20) in ProbeOffsetControl.c:

mustStoreCmd("G1 X%.2f Y%.2f getParameter(P_PROBE_OFFSET, X_STEPPER), getParameter(P_PROBE_OFFSET, Y_STEPPER), infoSettings.axis_speed[infoSettings.move_speed]); // move nozzle to XY probing coordinates and set feedrate

The nozzle has just homed (line 15) and I don't see the sense in moving it beyond this point. The P_PROBE_OFFSET values are ( in my case) beyond the physical capability of the nozzle, these offsets are used to calculate the distance from the probe to the nozzle. Trying to move the nozzle to the probe position is not a good idea and it will cause these horrible grinding noises.

[digant73]

@Octet-nl
After homing, the nozzle is moved on the probing point just to start using the usual paper to tune z offset.
In #1363 it was primarly reported the problem was on Z axis. If XY offset cannot be applied because they will be beyond the limits, it has no sense to set homing position on the edge of bed but it's enough to enable Z_SAFE_HOMING on Marlin FW (that is strongly recommended by Marlin FW when using a probe)

[Octet-nl]

As you mentioned correctly in #1363 the problem was not on the Z axis but on X and Y. At first it looked like a Z axis problem because it was caused by enabling Z offset.

When I had my BL-touch connected to the Z-endstop connector, it made sense to enable Z_SAFE_HOMING. Now I have the original Z-endstop connected, and the BL-touch is connected to the PROBE connector on the BTT SKR mini E3. This is working great and I don't want to change this. As a wise Marlin person once said: A probe is not an endstop and an endstop is not a probe.

(Reason for this is that the BLtouch once failed as an endstop so the nozzle drilled a 1 sq mm hole in the middle of the build plate. So for me no more homing there, it is not safe :p )

Apart from that, I don't see a reason for the movement of the nozzle to an area that can't be reached. I removed the offending statement and now everything works as expected. Is there any reason why I should not do this?

[Octet-nl]

As an experiment I removed the complete contents of probeOffsetEnable and probeOffsetDisable, except for the statements probe_offset_enable=false/true. This seems to work fine, probe offset can be toggled between on and off and there are no strange side-effects, the probeOffset can be set just like in the Marlin screen. Is there any reason why I should not do this either?

[digant73]

Understood your setup and the problem you had on the bed. The better solution is to make XY offset configurable based on preference/need. However, an HW setup forcing to use a probing point that is never reachable and far to be a good probing point for z offset is quite useless for me and I would tried a different setup

[Octet-nl]

XY offset is now measured with respect to the probe position as per Marlin config instructions.
Will keep this setup for the moment to see if anything strange happens. Thanks for thinking along.

[digant73]

XY offset is now measured with respect to the probe position as per Marlin config instructions.
Will keep this setup for the moment to see if anything strange happens. Thanks for thinking along.

try PR #1415. It should solve your problem (set the new parameter on config.ini to 0)