Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports Scroll gcode messages in terminal #1171

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

Subcircuit
Copy link
Contributor

@Subcircuit Subcircuit commented Oct 13, 2020

Description

On the gcode message display interface of the terminal, touch the upper half screen to turn pages up and touch the lower half screen to turn pages down.

screen:
        exit botton
+------------------------+
|                        |
|        page up         |
|                        |
+------------------------+
|                        |
|        page down       |
|                        |
+------------------------+

Related Issues

TFT35 E3 , TFT 43 , TFT 50 FLASH overflowed about 300 bytes

@radek8
Copy link
Contributor

radek8 commented Oct 13, 2020

How does the terminal window close?

@Subcircuit
Copy link
Contributor Author

How does the terminal window close?

Page turning is under the back button, and the back button is still there.

@radek8
Copy link
Contributor

radek8 commented Oct 14, 2020

OK, I missed the button. Thank you

@StarNamer
Copy link

@Subcircuit I just submitted a PR to add an extra column to the terminal keys. Originally (#1181 ), I was just going to add the F key (as I find typing the F parameter common as in 'G0 F60 Z0') but decided to add an extra column give a better layout (X Y Z E on one row) and allow a few extra keys (I, J, P, R). The only only place this conflicts with what you've done is that you've defined the bottom right position as ">". But as far as I can see, you don't use it for anything and I'm not aware of GCode using it. Is there a reason for this key being added? I didn't include it in my change, but since I added several punctuation keys on the ABC page, this could easily replace one of them since the only essential punctuation characters are "!" and "#" (for M32), "/" for file paths and "~" for 8.3 truncated filenames.

@oldman4U
Copy link
Contributor

Hello @Subcircuit.

Hope you are still monitoring this PR. Could you please add this to this PR, so that the FR related to the function you developed is automatically closed.

Thank you

resolves #1112

Copy link
Contributor

@digant73 digant73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi,
As an enhancement I will add a page/total pages indication in the same bar where you provided the "back" button. It helps the navigation through all the pages. I mean something like the following:

back__________1/4

@BlackDragon2020
Copy link

I will add that this was something that made me sad as using this function was one of the reasons to get it, but with no scrolling it was maybe 75% usable at best.

this was one of the bugs/ issues / FR i was going to look in to or recode. I will give this a look soon. thanks

@digant73
Copy link
Contributor

digant73 commented Oct 28, 2020

IMHO once the bar providing the "back" button is present, I would place into it also the UP and DOWN buttons. It makes more intuitive the navigation (instead of pressing on the upper or lower part of the screen. I would also place the bar in the bottom part of the screen instead of the upper part (that simply to avoid to cover with the finger the screen). I would provide something like:

+------------------------+
|
|
|
|
|
|
+------------------------+
| 1/4________^v__BACK|

@bigtreetech
Copy link
Owner

@digant73 hello, I've rearranged this menu.

@digant73
Copy link
Contributor

digant73 commented Oct 29, 2020

@digant73 hello, I've rearranged this menu.

Ok, I will have a look.
Something more I would like to change is also the background and foreground colors. Although I don't have problem with my eyes, the grey background and the black foreground are not the best choice (too less contrast). Normally the preferred colors are black for the background and yellow (or orange) for the foreground. However, I could work on these minor improvements in the future (after this PR is merged).
My idea is also to review the main page. The "send" and "back" buttons should be located in the bottom part. They are more compliant with the standard menus (where the back button is in the bottom part of the screen). Also it makes (IMHO) more comfortable the use of the buttons. Also that blue and yellow colors seems not consistent with the rest of the layout. Just my opinion

EDIT: @bigtreetech I had a look to the new changes. IMHO they are better than the previous version. More intuitive and easy to use. Obviously, thanks to Subcircuit for his good idea to provide a multi page terminal

@bigtreetech bigtreetech merged commit 0453f50 into bigtreetech:master Nov 2, 2020
@StarNamer StarNamer mentioned this pull request Nov 2, 2020
Manu512 pushed a commit to Manu512/BIGTREETECH-TouchScreenFirmware that referenced this pull request Nov 3, 2020
Co-authored-by: Msq001 <alansayyeah@gmail.com>
delwinbest added a commit to delwinbest/BIGTREETECH-TouchScreenFirmware that referenced this pull request Nov 21, 2020
* master: (114 commits)
  Avoid marking coordinate as unknown when parsing a M18/M84 S<timeout> (bigtreetech#1243)
  Update language_ru.h (bigtreetech#1261)
  MKS_TFT_28 as own compile target (bigtreetech#1246)
  Bootloader for display TFT50 V3.0 (bigtreetech#1101)
  Update Hungarian Language (bigtreetech#1247)
  Temperature update when printing from onboard SD, M155 instead of M105 for query temperature (bigtreetech#1244)
  Added a way to make a manual input to screen showing a value ( Temp, flow , speed etc...) (bigtreetech#1104)
  Improved Terminal menu based on TFT size and resolution (bigtreetech#1231)
  Add support for Home Offset (bigtreetech#1198)
  Add support to be able to control case light (bigtreetech#1214)
  improved Terminal menu (bigtreetech#1227)
  Language pack auto-generate script (bigtreetech#1215)
  Update French Translation (bigtreetech#1216)
  Update language_de.h (bigtreetech#1219)
  Fixed compiler warnings (bigtreetech#1220)
  Update language_ru.h (bigtreetech#1221)
  Update language_ru.ini (bigtreetech#1222)
  Update language CZ (bigtreetech#1223)
  sync upsteam branch (bigtreetech#1171)
  Fix to display M117 messages in info area (bigtreetech#1189)
  ...

# Conflicts:
#	platformio.ini
jeffeb3 pushed a commit to V1EngineeringInc/BIGTREETECH-TouchScreenFirmware that referenced this pull request Nov 10, 2021
Co-authored-by: Msq001 <alansayyeah@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants