Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Mesh Bed Leveling + optimized some code defining new API, improvements and bug fixes #1111

Merged
merged 9 commits into from
Sep 25, 2020

Conversation

digant73
Copy link
Contributor

@digant73 digant73 commented Sep 20, 2020

Description

Improvements:

  • defined new APIs:
  1. BabystepControl
  2. ProbeOffsetControl
    reusable for Babystep, Probe Offset, MBL and the future Mesh editor
  • Added BL menu hosting all common BL features (Auto and Manual) such as:
    • ABL, UBL and MBL menu
    • ZFade
    • BL on/off
    • a future Mesh Editor
  • Added Mesh Bed Leveling menu
  • PID: minor improvements
  • other improvements

Fixes:

PR Status:
FINAL: the PR is ready to be merged on BTT main branch

NOTE:
Previous FLASH space problems were fixed. Now it's about 87% of FLASH usage on all the TFT variants

@digant73
Copy link
Contributor Author

digant73 commented Sep 20, 2020

@bigtreetech The failed checks are related to no flash space availbale on TFT35 E3 V3.0 and above. With all other TFTs up to TFT35 there is no problem. Is there any solution applicable to solve the problem (e.g. make configurable the languages to include) or we can say THE END :-)?

@bigtreetech
Copy link
Owner

Yes. At present, all language characters occupy about 70-80KBytes of flash memory. we can add the macro definition to select the language to use in the source code to reduce the memory usage.
And, The current source code also needs to be cleaned up to reduce some duplicate code.
And we will do it in next work.
Thanks for your hard work!

@digant73
Copy link
Contributor Author

digant73 commented Sep 21, 2020

@bigtreetech Good thanks. I will mark my PR as draft version, updating it with all your next official updates. I will also start to develop the Mesh Editor.

br.

@digant73 digant73 marked this pull request as draft September 21, 2020 07:39
@digant73 digant73 marked this pull request as ready for review September 21, 2020 07:47
@digant73 digant73 marked this pull request as draft September 21, 2020 07:48
@traffic-light
Copy link
Contributor

@digant73
So you're about to make the #288 ?

Then I will quit working on it...

@Hukuma1
Copy link

Hukuma1 commented Sep 21, 2020

Combine your efforts @traffic-light and @digant73! :)

@digant73
Copy link
Contributor Author

@traffic-light
yes, I''m starting to work on it during some free time.
First I will work on the GUI layout and then to the parser

@traffic-light
Copy link
Contributor

traffic-light commented Sep 22, 2020

@bigtreetech maybe it's handy to change the names, for example en_cancel, without the language subscript. So for the example given: en_cancel into cancel.

This way it's easier to implement new words in all languages files.

@digant73 digant73 marked this pull request as ready for review September 22, 2020 19:39
@digant73
Copy link
Contributor Author

digant73 commented Sep 22, 2020

@bigtreetech
Previous FLASH space problems were fixed. Now it's about 87% of FLASH usage on all the TFT variants.
Optimized some code defining new APIs to handle babystep and probe offset.
Those APIs are used also by the new MBL menu and the future Mesh editor.
My PR is in final version and could be merged on your main branch

@digant73 digant73 changed the title Added Mesh Bed Leveling + improvements and bug fixes Added Mesh Bed Leveling + optimized some code defining new API, improvements and bug fixes Sep 22, 2020
@ETE-Design
Copy link

@digant73 Could you mabye look at the Runout Sensor, seems like it is not working, at least when you have it connected direct to the mainboard :-( The Runout trigger, but the TFT does nothing...

@radek8
Copy link
Contributor

radek8 commented Sep 23, 2020

Yes. At present, all language characters occupy about 70-80KBytes of flash memory. we can add the macro definition to select the language to use in the source code to reduce the memory usage.
And, The current source code also needs to be cleaned up to reduce some duplicate code.
And we will do it in next work.
Thanks for your hard work!

@bigtreetech
What if there were only two languages in the code. Primary - English and secondary also English.
In the display menu I would be able to select only the primary and secondary language, but the secondary jakzyk could be overwritten, for example, by using the language.ini file at boot time?
A set of language.ini files would then be available, which would be easily user configurable

@freez12
Copy link

freez12 commented Sep 23, 2020

Manual mesh is not getting saved and when i do a Manual mesh leveling i always get m851 unknowen commad.

@radek8
Copy link
Contributor

radek8 commented Sep 24, 2020

Manual mesh is not getting saved and when i do a Manual mesh leveling i always get m851 unknowen commad.

You do not have Baby steping allowed in Marlin

@freez12
Copy link

freez12 commented Sep 24, 2020

Manual mesh is not getting saved and when i do a Manual mesh leveling i always get m851 unknowen commad.

You do not have Baby steping allowed in Marlin

i hve Babystepping enabled in marlin when i use lcd mode everything is working mmbl also.

@bigtreetech bigtreetech merged commit e5803a1 into bigtreetech:master Sep 25, 2020
Manu512 pushed a commit to Manu512/BIGTREETECH-TouchScreenFirmware that referenced this pull request Nov 3, 2020
…vements and bug fixes (bigtreetech#1111)

* Added Mesh Bed Leveling

* cleanup

* cleanup

* minor changes

* optimized code + cleanup

* created API for Babystep and Probe Offset used by new MBL and next Mesh editor

* minor cleanup

* minor changes

* minor changes
jeffeb3 pushed a commit to V1EngineeringInc/BIGTREETECH-TouchScreenFirmware that referenced this pull request Nov 10, 2021
…vements and bug fixes (bigtreetech#1111)

* Added Mesh Bed Leveling

* cleanup

* cleanup

* minor changes

* optimized code + cleanup

* created API for Babystep and Probe Offset used by new MBL and next Mesh editor

* minor cleanup

* minor changes

* minor changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants