-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notification window when pressed on title bar and info-box, Add new TFT70 Status Screen, Fix FAN_CTRL_COUNT error during config upload & clean up #1060
Conversation
Add notification window to show last 3 messages received from printer when pressed on titlebar.
Nice. Was planning to do this by myself 😊 |
Gurmeet is my hero;-) |
Come on BTT merge this to the Master branch. |
Especially because it's fixing a bug what's pretty annoying. |
- Add a new status screen for TFT70 - BMP images on SPIflash are now stored with dimensions. - cleanup and remove unnecessary code and remove some global variables to reduce ram usage.
The fonts on TFT28 & TFT35 status screen were not meant to be larger. |
if the preheat menu is freezing you may reflash the config file |
Wouldn‘t it be good to have a kind of firmware vs config.ini check with a mismatch warning!? |
@oldman4U |
👍🏻 |
@discip your config file is not being read by the TFT a correct update will show a white progress bar and keyword counts being updated. if not then it is not being updated. I fixed some issue with the update process. Try with the latest commit. |
@GregSKR are you using the precompiled binaries or compiling yourself? |
@guruathwal this is what I always do:
This is what I did a few hours ago, config.ini looks like crashing at loading. I see you made a correction for that.
But still no notification history... |
THANK YOU! 👍I second what @GregSKR stated above. |
I believe i could find some time tomorrow and do some tests. Got a brand new SKR v1.4 and have TFT 35 E3 and TFT 28 to test, as well as SKR E3 DIP and SKR Pro v1.1. Any particular combination i should test? Let me know |
@GregSKR those messages are ignored by the firmware and only messages received from the printer are stored in the notification menu. |
@guruathwal Oh, my bad, didn't notice there is some filtering! I just tested with M118 and... got it!!! |
@guruathwal
|
This is a promising update. Thank you for your time @guruathwal :-) (the font/ icon/ ini check is really a great thing :-) ) |
line 21 "REPORT_FAN_CHANGE (in Configuration_adv.h)" referring to line 3114 of config_adv (version 020006) seems to be irrelevant now..? (version 020008) guessing it doesnt matter but confusing and should be removed from top of config.ini, where it says you must enable it. |
@charakaSamawry it is still relevant. why is it confusing to enable a line in marlin firmware? |
In version 20008 that line does not exist.
|
So it does thank you. Weird I did search it in vscode .......no caps maybe 🤷♂️didn’t think that mattered though |
im still confused lol! i dont have the line added on july 15th. but the change shows in my fork on july 15th. My fork also shows as uptodate with bugfix .. i mustve buggered up somewhere i guess.. my forks and changes are all public. ill let u knw when i find what i did lol |
🤷♂️ lost some 'S's in http:// links when i changed some config stuff as well... sorry im a wolly |
…ew TFT70 Status Screen, Fix FAN_CTRL_COUNT error during config upload & clean up (bigtreetech#1060) * Add notification window when pressed on titlebar Add notification window to show last 3 messages received from printer when pressed on titlebar. * open notification window when pressed on info box in status screen * fix infobox touch & button display * Fix FAN_CTRL_COUNT error during config upload * remove global variables * cleanup and add new statusscreen for tft70 - Add a new status screen for TFT70 - BMP images on SPIflash are now stored with dimensions. - cleanup and remove unnecessary code and remove some global variables to reduce ram usage. * Update language_en.h * add auto-detect heated chamber and machine size * fix some bugs * fix text display on statusscreen * Update PreheatMenu.c * Add flash data & config check * update precompiled bin Co-authored-by: BigTreeTech <38851044+bigtreetech@users.noreply.github.com>
…ew TFT70 Status Screen, Fix FAN_CTRL_COUNT error during config upload & clean up (bigtreetech#1060) * Add notification window when pressed on titlebar Add notification window to show last 3 messages received from printer when pressed on titlebar. * open notification window when pressed on info box in status screen * fix infobox touch & button display * Fix FAN_CTRL_COUNT error during config upload * remove global variables * cleanup and add new statusscreen for tft70 - Add a new status screen for TFT70 - BMP images on SPIflash are now stored with dimensions. - cleanup and remove unnecessary code and remove some global variables to reduce ram usage. * Update language_en.h * add auto-detect heated chamber and machine size * fix some bugs * fix text display on statusscreen * Update PreheatMenu.c * Add flash data & config check * update precompiled bin Co-authored-by: BigTreeTech <38851044+bigtreetech@users.noreply.github.com>
GUI_DispLenString
to truncate long text and avoid text clipping.fan_ctrl_count
error during config upload (error in config.ini #1064)Fixes #1064