Add notification window when pressed on title bar and info-box, Add new TFT70 Status Screen, Fix FAN_CTRL_COUNT error during config upload & clean up #1060

guruathwal · 2020-09-05T07:22:13Z

Add notification window to show last 3 messages received from the printer/machine when pressed on Title Bar on any screen and the Info-box on the Status screen.
Show notification dot in the top left corner when notifications are received.
Add truncate option in GUI_DispLenString to truncate long text and avoid text clipping.
Fix fan_ctrl_count error during config upload (error in config.ini #1064)
Add a new status screen for TFT70
BMP images on SPIflash are now stored with dimensions.
Clean-up and remove unnecessary code and remove some global variables to reduce RAM usage.
Add auto-detect for chamber heater and machine size (needs enabling M115_GEOMETRY_REPORT in marlin firmware).
Add flash data/config check to notify if updating font, icons or config is required after a firmware update.

Fixes #1064

Add notification window to show last 3 messages received from printer when pressed on titlebar.

traffic-light · 2020-09-05T20:30:33Z

Nice. Was planning to do this by myself 😊

oldman4U · 2020-09-07T09:22:56Z

Gurmeet is my hero;-)

blueeagle69 · 2020-09-08T13:33:59Z

Come on BTT merge this to the Master branch.

traffic-light · 2020-09-08T14:39:43Z

Come on BTT merge this to the Master branch.

Especially because it's fixing a bug what's pretty annoying.

- Add a new status screen for TFT70 - BMP images on SPIflash are now stored with dimensions. - cleanup and remove unnecessary code and remove some global variables to reduce ram usage.

TFT/src/User/API/Language/language_en.h

guruathwal · 2020-09-11T04:49:16Z

The fonts on TFT28 & TFT35 status screen were not meant to be larger.

guruathwal · 2020-09-11T04:51:13Z

if the preheat menu is freezing you may reflash the config file

oldman4U · 2020-09-11T05:36:57Z

Wouldn‘t it be good to have a kind of firmware vs config.ini check with a mismatch warning!?

guruathwal · 2020-09-11T05:45:26Z

@oldman4U
almost done...

oldman4U · 2020-09-11T05:46:12Z

👍🏻

guruathwal · 2020-09-11T17:58:50Z

@discip your config file is not being read by the TFT a correct update will show a white progress bar and keyword counts being updated. if not then it is not being updated. I fixed some issue with the update process. Try with the latest commit.

guruathwal · 2020-09-11T18:03:32Z

@GregSKR are you using the precompiled binaries or compiling yourself?

GregSKR · 2020-09-11T18:40:15Z

@guruathwal this is what I always do:

download latest version on your fork
change platformio.ini for TFT35V2.0 and config.ini for my personal parameters
compile it with Visual Studio Code
do a full flash (firmware+fonts+bmp+config.ini)

This is what I did a few hours ago, config.ini looks like crashing at loading. I see you made a correction for that.
So just did it again now, with your latest commit and

preheat menu is now ok, all labels displayed, no freezing 👍
the fonts on status screen are back to normal 👍
(and custom menus are ok, too)
THANKS FOR THIS 👍 😃

But still no notification history...
When power my Ender-3, I got 2 notifications on my TFT (echo: fade height 10.0 and echo: bed levelling ON).
Go to Terminal and run M117 TEST
Back to status screen echo: TEST is showing
But history is still empty... 😢

discip · 2020-09-11T20:20:41Z

@guruathwal

THANK YOU! 👍

I second what @GregSKR stated above.
The good and the none working as well.

oldman4U · 2020-09-11T21:51:27Z

I believe i could find some time tomorrow and do some tests.

Got a brand new SKR v1.4 and have TFT 35 E3 and TFT 28 to test, as well as SKR E3 DIP and SKR Pro v1.1.

Any particular combination i should test?

Let me know

guruathwal · 2020-09-12T04:11:32Z

@GregSKR those messages are ignored by the firmware and only messages received from the printer are stored in the notification menu.
try sending messages with M118

GregSKR · 2020-09-12T11:38:18Z

@guruathwal Oh, my bad, didn't notice there is some filtering! I just tested with M118 and... got it!!!
Thanks again, looks like this PR is ready for merging ❤️

digant73 · 2020-09-13T09:51:43Z

@guruathwal
hi, a possible cleanup in the "hostActionCommands" function on parseAck.c. I will change the dialog type to DIALOG_TYPE_ALERT for the three dialog boxes below (starting at line 236). As you see, currently INFO and ERROR are used while for the buzzer a more appropriate notify sound is used:

    BUZZER_PLAY(sound_notify);
    popupReminder(DIALOG_TYPE_INFO,(u8 *)"Message", (u8 *)hostAction.prompt_begin);
    break;
  case 1:
    BUZZER_PLAY(sound_notify);
    showDialog(DIALOG_TYPE_ERROR, (u8*)"Action command", (u8 *)hostAction.prompt_begin, (u8 *)hostAction.prompt_button1, NULL, breakAndContinue, NULL, NULL);
    break;
  case 2:
    BUZZER_PLAY(sound_notify);
    showDialog(DIALOG_TYPE_ERROR, (u8*)"Action command", (u8 *)hostAction.prompt_begin, (u8 *)hostAction.prompt_button1, (u8 *)hostAction.prompt_button2, resumeAndPurge, resumeAndContinue, NULL);

traffic-light · 2020-09-13T21:31:45Z

This is a promising update. Thank you for your time @guruathwal :-)

(the font/ icon/ ini check is really a great thing :-) )

charakaSamawry · 2020-10-28T23:12:23Z

line 21 "REPORT_FAN_CHANGE (in Configuration_adv.h)" referring to line 3114 of config_adv (version 020006) seems to be irrelevant now..? (version 020008) guessing it doesnt matter but confusing and should be removed from top of config.ini, where it says you must enable it.

guruathwal · 2020-10-29T04:53:58Z

@charakaSamawry it is still relevant. why is it confusing to enable a line in marlin firmware?

charakaSamawry · 2020-10-29T13:34:05Z

In version 20008 that line does not exist.

@charakaSamawry it is still relevant. why is it confusing to enable a line in marlin firmware?

guruathwal · 2020-10-29T14:07:24Z

It does
https://github.com/MarlinFirmware/Marlin/blob/50ba20fe1f27cdcb0f0f98f11cb42248dbc186f7/Marlin/Configuration_adv.h#L3205-L3207

charakaSamawry · 2020-10-29T18:27:19Z

It does
https://github.com/MarlinFirmware/Marlin/blob/50ba20fe1f27cdcb0f0f98f11cb42248dbc186f7/Marlin/Configuration_adv.h#L3205-L3207

So it does thank you. Weird I did search it in vscode .......no caps maybe 🤷‍♂️didn’t think that mattered though

charakaSamawry · 2020-10-29T18:56:37Z

im still confused lol! i dont have the line added on july 15th. but the change shows in my fork on july 15th. My fork also shows as uptodate with bugfix .. i mustve buggered up somewhere i guess.. my forks and changes are all public. ill let u knw when i find what i did lol

charakaSamawry · 2020-10-29T19:27:45Z

charakaSamawry/Marlin@4f50b68

🤷‍♂️ lost some 'S's in http:// links when i changed some config stuff as well... sorry im a wolly

…ew TFT70 Status Screen, Fix FAN_CTRL_COUNT error during config upload & clean up (bigtreetech#1060) * Add notification window when pressed on titlebar Add notification window to show last 3 messages received from printer when pressed on titlebar. * open notification window when pressed on info box in status screen * fix infobox touch & button display * Fix FAN_CTRL_COUNT error during config upload * remove global variables * cleanup and add new statusscreen for tft70 - Add a new status screen for TFT70 - BMP images on SPIflash are now stored with dimensions. - cleanup and remove unnecessary code and remove some global variables to reduce ram usage. * Update language_en.h * add auto-detect heated chamber and machine size * fix some bugs * fix text display on statusscreen * Update PreheatMenu.c * Add flash data & config check * update precompiled bin Co-authored-by: BigTreeTech <38851044+bigtreetech@users.noreply.github.com>

guruathwal added 2 commits September 5, 2020 12:02

Add notification window when pressed on titlebar

b7b2430

Add notification window to show last 3 messages received from printer when pressed on titlebar.

open notification window when pressed on info box in status screen

bcca291

guruathwal marked this pull request as draft September 5, 2020 15:39

fix infobox touch & button display

a1acc40

guruathwal marked this pull request as ready for review September 6, 2020 04:28

Fix FAN_CTRL_COUNT error during config upload

00974e6

guruathwal changed the title ~~Add notification window when pressed on title bar and info-box~~ Add notification window when pressed on title bar and info-box, Fix FAN_CTRL_COUNT error during config upload Sep 7, 2020

remove global variables

400bfaf

cleanup and add new statusscreen for tft70

a26f043

- Add a new status screen for TFT70 - BMP images on SPIflash are now stored with dimensions. - cleanup and remove unnecessary code and remove some global variables to reduce ram usage.

radek8 reviewed Sep 8, 2020

View reviewed changes

TFT/src/User/API/Language/language_en.h Outdated Show resolved Hide resolved

guruathwal added 2 commits September 9, 2020 11:00

Update language_en.h

d6b50bb

add auto-detect heated chamber and machine size

8ca3341

guruathwal marked this pull request as draft September 9, 2020 16:33

guruathwal added 3 commits September 9, 2020 22:29

fix some bugs

ff9d390

fix text display on statusscreen

4f92cf6

Update PreheatMenu.c

3ab7f0c

Add flash data & config check

1370d17

guruathwal marked this pull request as ready for review September 11, 2020 18:01

guruathwal added 2 commits September 12, 2020 12:12

Merge remote-tracking branch 'upstream/master'

4e9f338

update precompiled bin

dd5218c

Merge branch 'master' into master

e346c19

bigtreetech merged commit 1825ef6 into bigtreetech:master Sep 16, 2020

radek8 mentioned this pull request Sep 17, 2020

[BUG] Update the print speed value when printing #1048

Closed

blueeagle69 mentioned this pull request Oct 8, 2020

[BUG] Gcode Filename letter followed by number shows ???? when printing from Onboard SD #1158

Closed

radek8 mentioned this pull request Nov 9, 2020

[BUG] Flow randomly changed from 100% to 10% during a print #1228

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add notification window when pressed on title bar and info-box, Add new TFT70 Status Screen, Fix FAN_CTRL_COUNT error during config upload & clean up #1060

Add notification window when pressed on title bar and info-box, Add new TFT70 Status Screen, Fix FAN_CTRL_COUNT error during config upload & clean up #1060

guruathwal commented Sep 5, 2020 •

edited

Loading

traffic-light commented Sep 5, 2020

oldman4U commented Sep 7, 2020

blueeagle69 commented Sep 8, 2020

traffic-light commented Sep 8, 2020

guruathwal commented Sep 11, 2020

guruathwal commented Sep 11, 2020

oldman4U commented Sep 11, 2020

guruathwal commented Sep 11, 2020

oldman4U commented Sep 11, 2020

guruathwal commented Sep 11, 2020 •

edited

Loading

guruathwal commented Sep 11, 2020

GregSKR commented Sep 11, 2020 •

edited

Loading

discip commented Sep 11, 2020

oldman4U commented Sep 11, 2020

guruathwal commented Sep 12, 2020

GregSKR commented Sep 12, 2020

digant73 commented Sep 13, 2020 •

edited

Loading

traffic-light commented Sep 13, 2020

charakaSamawry commented Oct 28, 2020

guruathwal commented Oct 29, 2020

charakaSamawry commented Oct 29, 2020

guruathwal commented Oct 29, 2020

charakaSamawry commented Oct 29, 2020

charakaSamawry commented Oct 29, 2020 •

edited

Loading

charakaSamawry commented Oct 29, 2020 •

edited

Loading

Add notification window when pressed on title bar and info-box, Add new TFT70 Status Screen, Fix FAN_CTRL_COUNT error during config upload & clean up #1060

Add notification window when pressed on title bar and info-box, Add new TFT70 Status Screen, Fix FAN_CTRL_COUNT error during config upload & clean up #1060

Conversation

guruathwal commented Sep 5, 2020 • edited Loading

traffic-light commented Sep 5, 2020

oldman4U commented Sep 7, 2020

blueeagle69 commented Sep 8, 2020

traffic-light commented Sep 8, 2020

guruathwal commented Sep 11, 2020

guruathwal commented Sep 11, 2020

oldman4U commented Sep 11, 2020

guruathwal commented Sep 11, 2020

oldman4U commented Sep 11, 2020

guruathwal commented Sep 11, 2020 • edited Loading

guruathwal commented Sep 11, 2020

GregSKR commented Sep 11, 2020 • edited Loading

discip commented Sep 11, 2020

THANK YOU! 👍

oldman4U commented Sep 11, 2020

guruathwal commented Sep 12, 2020

GregSKR commented Sep 12, 2020

digant73 commented Sep 13, 2020 • edited Loading

traffic-light commented Sep 13, 2020

charakaSamawry commented Oct 28, 2020

guruathwal commented Oct 29, 2020

charakaSamawry commented Oct 29, 2020

guruathwal commented Oct 29, 2020

charakaSamawry commented Oct 29, 2020

charakaSamawry commented Oct 29, 2020 • edited Loading

charakaSamawry commented Oct 29, 2020 • edited Loading

guruathwal commented Sep 5, 2020 •

edited

Loading

guruathwal commented Sep 11, 2020 •

edited

Loading

GregSKR commented Sep 11, 2020 •

edited

Loading

digant73 commented Sep 13, 2020 •

edited

Loading

charakaSamawry commented Oct 29, 2020 •

edited

Loading

charakaSamawry commented Oct 29, 2020 •

edited

Loading