Skip to content
This repository was archived by the owner on Jul 14, 2020. It is now read-only.

Add Karma example #3

Merged
merged 3 commits into from
Oct 23, 2018
Merged

Add Karma example #3

merged 3 commits into from
Oct 23, 2018

Conversation

Robdel12
Copy link
Contributor

What is this?

This adds Karma as an example that lives alongside the BigTest CLI.

const convert = require('koa-connect');
const history = require('connect-history-api-fallback');

const isTesting = process.env.NODE_ENV === 'testing';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably isn't needed. Should I delete it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea

@Robdel12 Robdel12 requested a review from wwilsman October 23, 2018 16:47
This also updates `@bigtest/interactor` & `@bigtest/mocha` since they
both rely on `@bigtest/convergence`.
Copy link
Contributor

@wwilsman wwilsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to just assume we rolled back changes from the other example and spun it off into another directory. In which case I'm going to opt out of reviewing code I technically wrote.

@Robdel12
Copy link
Contributor Author

@wwilsman Yep! hhaha that's what happened. I'm not crazy about maintaining two webpack configs and what not, but I don't think it's going to be that big of a deal.

@Robdel12 Robdel12 merged commit 853bfd9 into master Oct 23, 2018
@Robdel12 Robdel12 deleted the rd/add-karma-example-back branch October 23, 2018 20:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants