Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add htmx4s to scala server-examples #2722

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

eikek
Copy link
Contributor

@eikek eikek commented Jul 13, 2024

Description

Hi, I included my scala library to the examples section of the website (servers).

I did not run npm run test, because it is only a documentation change.
I did run zola check that reported a list of broken links, but it didn't include this new one :-).

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

@Telroshan Telroshan added the documentation Improvements or additions to documentation label Jul 13, 2024
@eikek
Copy link
Contributor Author

eikek commented Oct 4, 2024

Hi, wondering if I forgot something to do or is there anything I can improve in order for it being considered? Thank you! 🙏🏼

@Telroshan
Copy link
Collaborator

Nope, totally forgot about it 😆
Thanks for the reminder @eikek !

@Telroshan Telroshan merged commit 8a60c69 into bigskysoftware:master Oct 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants