Allow non-id selectors in hx-select-oob
to fix #2561
#2585
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes #2561. I retargeted it against
v1
as suggested on discord. I found this issue with thehx-select-oob
attribute while trying to help a beginner on discord. This technically breaks an obscure behavior of adding back#
to a selector if it does not begin with a#
. This behavior is neither documented nor tested. In fact, the documentation suggests you can use this with any CSS selector, not just id selectors(though it does not give an example).As I have explained in the issue, this can cause really strange behavior when combined with non-id selectors by reinterpreting them as id selectors(and that too not even properly).
Testing
I added tests for non-id selectors and tests for non-id selectors with colons. I also added missing tests for
hx-select-oob
with different swap stylesChecklist
master
for website changes,dev
forsource changes)
approved via an issue
npm run test
) and verified that it succeeded