Allow user to override Content-Type header #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexpetros
requested changes
Nov 5, 2023
alexpetros
added
bug
alexpetros
changed the title
I will add them within the next week |
|
Oh, also, needs to be retargeted against |
Yeap, i will change that after we find a solution. |
Telroshan
added
the
ready for review
alexpetros
removed
the
ready for review
alexpetros
reviewed
Nov 8, 2023
There was a problem hiding this comment.
Need to remove the two unrelated changes (@Telroshan is correct about splitting up unrelated PRs) and then we're good to go.
www/content/api.md
Outdated
| @@ -58,7 +58,7 @@ or | |||
| * `handler` - a callback that will handle the response HTML | |||
| * `target` - the target to swap the response into | |||
| * `swap` - how the response will be swapped in relative to the target | |||
| * `values` - values to submit with the request | |||
| * `values` - values to submit with the request (json object, not an array) | |||
src/htmx.js
Outdated
| @@ -3301,7 +3302,7 @@ return (function () { | |||
| }); | |||
| }); | |||
| triggerEvent(elt, 'htmx:beforeSend', responseInfo); | |||
| var params = useUrlParams ? null : encodeParamsForBody(xhr, elt, filteredParameters) | |||
| var params = useUrlParams ? null : encodeParamsForBody(xhr, elt, filteredParameters); | |||
There was a problem hiding this comment.
Please remove this change
|
Terrific, thank you! |
alexpetros
added
the
ready for review
|
beauty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using a 3rd party js library (openstreetmap) which returns me a
veryComplexObjectwhich i need to make an ajax request. At the moment htmx.ajax overwrites theContent-Type. With this commit we can do use anyContent-Typewe want.This works great. But it would be cool if we had more control over of some (if not all) htmx properties like
hx-push-url.