Limit max shard num to 64 (milvus-io#19776)

Signed-off-by: longjiquan <jiquan.long@zilliz.com> Signed-off-by: longjiquan <jiquan.long@zilliz.com>
bigsheeper · Oct 14, 2022 · cb51d41 · cb51d41
1 parent 8c9c167
commit cb51d41
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 0 deletions.
diff --git a/internal/rootcoord/constrant.go b/internal/rootcoord/constrant.go
@@ -6,4 +6,6 @@ const (
 	globalIDAllocatorSubPath  = "gid"
 	globalTSOAllocatorKey     = "timestamp"
 	globalTSOAllocatorSubPath = "tso"
+
+	maxShardNum = 64
 )
diff --git a/internal/rootcoord/create_collection_task.go b/internal/rootcoord/create_collection_task.go
@@ -50,6 +50,10 @@ func (t *createCollectionTask) validate() error {
 		return err
 	}
 
+	if t.Req.GetShardsNum() >= maxShardNum {
+		return fmt.Errorf("shard num (%d) exceeds limit (%d)", t.Req.GetShardsNum(), maxShardNum)
+	}
+
 	return nil
 }
 

diff --git a/internal/rootcoord/create_collection_task_test.go b/internal/rootcoord/create_collection_task_test.go
@@ -40,6 +40,17 @@ func Test_createCollectionTask_validate(t *testing.T) {
 		assert.Error(t, err)
 	})
 
+	t.Run("shard num exceeds limit", func(t *testing.T) {
+		task := createCollectionTask{
+			Req: &milvuspb.CreateCollectionRequest{
+				Base:      &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
+				ShardsNum: maxShardNum + 1,
+			},
+		}
+		err := task.validate()
+		assert.Error(t, err)
+	})
+
 	t.Run("normal case", func(t *testing.T) {
 		task := createCollectionTask{
 			Req: &milvuspb.CreateCollectionRequest{