Biosses + GAD refactor #84
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR: I need to change some aspects of how
baseruns in order to work with binary classification. I am not sure why that is the case but inspection of the target seems to return an explicit str as opposed to a List of strs which fails the assertion hereAdds BIOSSES + fixes GAD to reflec the new BLURB data. I needed to change some details on
base.pyin order to get this to work:Line 720 I was running into an assertion error. Inspection of the culprit suggested I was returning a str (Yes or No) not a List of str; Changing this into
target = [self.doc_to_target(doc)]fixes the problem for meLine 1055 I added any other tasks that appear in the prompts here. In this case, Accuracy as already included.
NOTE this should be accompanied with prompts from here