RFC: Core::Handle - make simple_query a little less simple #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thefatphil
force-pushed
the
simple-join
branch
2 times, most recently
from
6ac9ccb to
b67d3f5
Compare
The simplest of joins is to take two tables, and join on a single
field from each table. If we're agreed that's simple, then it is
worth supporting.
So, rather than:
$urow = database->quick_select('users', { login => $uname });
$crow = database->quick_select('countries', { id => $urow->{'country'} });
One can now do:
$row = database->quick_select({ users=>'country', countries=>'id' },
{ login=>$uname });
(defaulting to inner join), or:
$row = database->quick_select({ users=>'country', countries=>'id' },
{ login=>$uname }, { join_type=>'left', join_order=>['users','countries'] });
The order field is only needed because of the non-ordered nature of
hashes, neither of the tables has precedence, so it's not clear which is
'left' and which is 'right'.
Signed-off-by: Phil Carmody <pc+github@asdf.org>
|
Version 2 is better, closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The simplest of joins is to take two tables, and join on a single
field from each table. If we're agreed that's simple, then it is
worth supporting.
So, rather than:
$urow = database->quick_select('users', { login => $uname });
$crow = database->quick_select('countries', { id => $urow->{'country'} });
One can now do:
$row = database->quick_select({ users=>'country', countries=>'id' },
{ login=>$uname });
(defaulting to inner join), or:
$row = database->quick_select({ users=>'country', countries=>'id' },
{ login=>$uname }, { join_type=>'left', join_order=>['users','countries'] });
The order field is only needed because of the non-ordered nature of
hashes, neither of the tables has precedence, so it's not clear which is
'left' and which is 'right'.
Signed-off-by: Phil Carmody pc+github@asdf.org