factor out _generate_where_clauses for #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Let me know if you want a merge and release, @bigpresh (of course you can do it yourself too :)) |
|
awesome, thanks for the quick review, ambs |
| return; | ||
| if ($where) { | ||
| my ($where_sql, @where_binds) = $self->_generate_where_clauses( $where ); | ||
| return unless $where_sql; # there was a problem |
There was a problem hiding this comment.
I wonder if we shouldn't carp here, rather than silently return undef - if we didn't generate any SQL something was clearly very wrong.
|
At a quick skim-over it looks sane, other than a couple of tiny niggles, but I'd like to re-review it tomorrow with fresh eyes before I merge and release. |
|
@bigpresh - repushed with your input integrated. |
|
Merged, and D::P::D::Core 0.15 released - thanks Josh! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bigpresh/Dancer-Plugin-SimpleCRUD#57
For discussion @bigpresh