Skip to content

Conversation

SysPete
Copy link
Contributor

@SysPete SysPete commented Mar 29, 2016

Any plugins which use this plugin will not work when plugin1's
plugin_config keyword is used and so if we smell plugin2 we get config
via $dsl->config instead. This is needed by
Dancer2::Plugin::Auth::Extensible::Provider::Database.

Thanks to yanick for the pointer.

@ambs
Copy link
Collaborator

ambs commented Mar 29, 2016

Looks good to me. Any idea when the Plugin2 system will be out?

Will merge from home, so I can have the time to add credits on ChangeLog.
Best

@SysPete
Copy link
Contributor Author

SysPete commented Mar 29, 2016

On 29/03/16 17:53, Alberto Simões wrote:

Looks good to me. Any idea when the Plugin2 system will be out?

Will merge from home, so I can have the time to add credits on ChangeLog.
Best

Excellent! Once you get a new release out, and I get a PR to ironcamel
so he can release a new Plugin::DBIC, then just 2 plugins which consume
P::Database and P::DBIC need a final cleanup to be released in sync with
new Dancer2. So hopefully plugin2 will be in the wild really soon.

P

@SysPete
Copy link
Contributor Author

SysPete commented Mar 29, 2016

Me being a complete idiot today got the plugin2 check wrong. Fixed with latest commit. I promise I won't push anything else.

SysPete added 2 commits March 29, 2016 19:25
Any plugins which use this plugin will not work when plugin1's
plugin_config keyword is used and so if we smell plugin2 we get config
via $dsl->config instead. This is needed by
Dancer2::Plugin::Auth::Extensible::Provider::Database.

Thanks to yanick for the pointer.
@ambs ambs merged commit 3b424f3 into bigpresh:master Mar 30, 2016
@ambs
Copy link
Collaborator

ambs commented Mar 30, 2016

Dancer2-Plugin-Database-2.16.tar.gz uploaded to CPAN.
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants