Join the reconnection and connection codepaths #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous patch solved the problem with a half measure: it simply copied the missing part of the reconnection flow from the connection flow (namely, saving the DBI handle). It's better to just use the same code. Short term benefit: the last_connection_check timestamp will be set at connection time, instead of at the next call after reconnect, which allows to spare a connection check on the next call. Long term benefit: fewer chances of diverging further.
bigpresh
added a commit
that referenced
this pull request
Mar 6, 2014
Join the reconnection and connection codepaths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous patch solved the problem with a half measure: it simply
copied the missing part of the reconnection flow from the connection
flow (namely, saving the DBI handle). It's better to just use the
same code.
Short term benefit: the last_connection_check timestamp
will be set at connection time, instead of at the next call after
reconnect, which allows to spare a connection check on the next
call.
Long term benefit: fewer chances of diverging further.