Skip to content

Add ratings info #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 92 commits into
base: main
Choose a base branch
from
Open

Add ratings info #230

wants to merge 92 commits into from

Conversation

spahrenk
Copy link
Contributor

Add ratings information to IHPWH presets. Enable reading/writing from json schema.

spahrenk added 30 commits April 7, 2025 16:09
…gs-info

# Conflicts:
#	scripts/python/data_model/build_data_model.py
#	src/HPWH.cc
#	src/HPWH.hh
#	src/HPWHpresets.cc
#	src/Tank.cc
…uct-info

# Conflicts:
#	scripts/python/data_model/build_data_model.py
#	src/Condenser.cc
#	src/HPWH.cc
#	src/HPWHUtils.cc
#	src/HPWHUtils.hh
#	src/Resistance.cc
#	test/models_json/AOSmithCAHP120.json
#	test/models_json/AOSmithHPTS40.json
#	test/models_json/AOSmithHPTS50.json
#	test/models_json/AOSmithHPTS66.json
#	test/models_json/AOSmithHPTS80.json
#	test/models_json/AOSmithHPTU50.json
#	test/models_json/AOSmithHPTU66.json
#	test/models_json/AOSmithHPTU80.json
#	test/models_json/AOSmithHPTU80_DR.json
#	test/models_json/AOSmithPHPT60.json
#	test/models_json/AOSmithPHPT80.json
#	test/models_json/AWHSTier3Generic40.json
#	test/models_json/AWHSTier3Generic50.json
#	test/models_json/AWHSTier3Generic65.json
#	test/models_json/AWHSTier3Generic80.json
#	test/models_json/AWHSTier4Generic40.json
#	test/models_json/AWHSTier4Generic50.json
#	test/models_json/AWHSTier4Generic65.json
#	test/models_json/AWHSTier4Generic80.json
#	test/models_json/AquaThermAire.json
#	test/models_json/BWC2020_65.json
#	test/models_json/BradfordWhiteAeroThermRE2H50.json
#	test/models_json/BradfordWhiteAeroThermRE2H65.json
#	test/models_json/BradfordWhiteAeroThermRE2H80.json
#	test/models_json/ColmacCxA_10_MP.json
#	test/models_json/ColmacCxA_10_SP.json
#	test/models_json/ColmacCxA_15_MP.json
#	test/models_json/ColmacCxA_15_SP.json
#	test/models_json/ColmacCxA_20_MP.json
#	test/models_json/ColmacCxA_20_SP.json
#	test/models_json/ColmacCxA_25_MP.json
#	test/models_json/ColmacCxA_25_SP.json
#	test/models_json/ColmacCxA_30_MP.json
#	test/models_json/ColmacCxA_30_SP.json
#	test/models_json/ColmacCxV_5_MP.json
#	test/models_json/ColmacCxV_5_SP.json
#	test/models_json/GE.json
#	test/models_json/GE2014STDMode.json
#	test/models_json/GE2014STDMode_80.json
#	test/models_json/GE502014.json
#	test/models_json/GE802014.json
#	test/models_json/Generic1.json
#	test/models_json/Generic2.json
#	test/models_json/Generic3.json
#	test/models_json/GenericUEF217.json
#	test/models_json/LG_APHWC50.json
#	test/models_json/LG_APHWC80.json
#	test/models_json/NyleC125A_C_MP.json
#	test/models_json/NyleC125A_C_SP.json
#	test/models_json/NyleC125A_MP.json
#	test/models_json/NyleC125A_SP.json
#	test/models_json/NyleC185A_C_MP.json
#	test/models_json/NyleC185A_C_SP.json
#	test/models_json/NyleC185A_MP.json
#	test/models_json/NyleC185A_SP.json
#	test/models_json/NyleC250A_C_MP.json
#	test/models_json/NyleC250A_C_SP.json
#	test/models_json/NyleC250A_MP.json
#	test/models_json/NyleC250A_SP.json
#	test/models_json/NyleC25A_SP.json
#	test/models_json/NyleC60A_C_MP.json
#	test/models_json/NyleC60A_C_SP.json
#	test/models_json/NyleC60A_MP.json
#	test/models_json/NyleC60A_SP.json
#	test/models_json/NyleC90A_C_MP.json
#	test/models_json/NyleC90A_C_SP.json
#	test/models_json/NyleC90A_MP.json
#	test/models_json/NyleC90A_SP.json
#	test/models_json/QAHV_N136TAU_HPB_SP.json
#	test/models_json/Rheem2020Build40.json
#	test/models_json/Rheem2020Build50.json
#	test/models_json/Rheem2020Build65.json
#	test/models_json/Rheem2020Build80.json
#	test/models_json/Rheem2020Prem40.json
#	test/models_json/Rheem2020Prem50.json
#	test/models_json/Rheem2020Prem65.json
#	test/models_json/Rheem2020Prem80.json
#	test/models_json/RheemHB50.json
#	test/models_json/RheemHBDR2250.json
#	test/models_json/RheemHBDR2265.json
#	test/models_json/RheemHBDR2280.json
#	test/models_json/RheemHBDR4550.json
#	test/models_json/RheemHBDR4565.json
#	test/models_json/RheemHBDR4580.json
#	test/models_json/RheemHPHD135.json
#	test/models_json/RheemHPHD60.json
#	test/models_json/RheemPlugInDedicated40.json
#	test/models_json/RheemPlugInDedicated50.json
#	test/models_json/RheemPlugInShared40.json
#	test/models_json/RheemPlugInShared50.json
#	test/models_json/RheemPlugInShared65.json
#	test/models_json/RheemPlugInShared80.json
#	test/models_json/Sanden120.json
#	test/models_json/Sanden40.json
#	test/models_json/Sanden80.json
#	test/models_json/Scalable_MP.json
#	test/models_json/Stiebel220e.json
#	test/models_json/TamScalable_SP.json
#	test/models_json/TamScalable_SP_2X.json
#	test/models_json/TamScalable_SP_Half.json
#	test/models_json/UEF2generic.json
#	test/models_json/restankRealistic.json
@spahrenk spahrenk marked this pull request as draft April 30, 2025 15:29
@spahrenk spahrenk requested a review from nealkruis April 30, 2025 18:26
@spahrenk spahrenk marked this pull request as ready for review April 30, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant