[BUGFIX] Limit the range of parameters in IRT and MIRT #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #33 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 32 32
Lines 1148 1162 +14
=========================================
+ Hits 1148 1162 +14
Continue to review full report at Codecov.
|
tswsxk
requested changes
Oct 21, 2021
Collaborator
|
coverage should be 100% |
tswsxk
requested changes
Oct 21, 2021
EduCDM/IRT/GD/IRT.py
Outdated
| else: | ||
| a = F.softplus(a) | ||
| if torch.max(theta != theta) or torch.max(a != a) or torch.max(b != b): | ||
| raise Exception('Error:theta,a,b may contains nan! The value_range or a_range is too large.') |
EduCDM/MIRT/MIRT.py
Outdated
| a = F.softplus(a) | ||
| b = torch.squeeze(self.b(item), dim=-1) | ||
| if torch.max(theta != theta) or torch.max(a != a) or torch.max(b != b): | ||
| raise Exception('Error:theta,a,b may contains nan! The a_range is too large.') |
|
|
||
| def test_train_with_large_range(data, conf, tmp_path): | ||
| user_num, item_num = conf | ||
| try: |
Collaborator
There was a problem hiding this comment.
Use pytest.raise to test exception
Collaborator
|
Still, use |
tswsxk
previously approved these changes
Oct 22, 2021
tswsxk
previously approved these changes
Oct 22, 2021
tswsxk
previously approved these changes
Oct 23, 2021
Collaborator
|
The description is not intact @ViviHong200709, you should breifly describe what is changed in |
ViviHong200709
changed the title
tswsxk
approved these changes
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for sending a pull request!
Please make sure you click the link above to view the contribution guidelines,
then fill out the blanks below.
Description
Limit the range of parameters in IRT and MIRT
What does this implement/fix? Explain your changes.
...
Pull request type
Changes
EduCDM/EduCDM/IRT/GD/IRT.py: In IRT,Use value_range to limit the range of theta and b.Also use sigmoid(c) make sure that c is limit to [0,1].
EduCDM/EduCDM/MIRT/MIRT.py, EduCDM/EduCDM/MIRT/MIRT.py: In IRT and MIRT,Use a_range to limit the range of a. If a_range is not given ,use softplus(a) to make sure a>0.
Does this close any currently open issues?
#31
Any relevant logs, error output, etc?
no
Checklist
Before you submit a pull request, please make sure you have to following:
Essentials
Comments